linux-kernel - [PATCH] genksyms: fix file pointer leaks on error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20260117102602.534734-1-geoffreyhe2@gmail.com>
Date: Sat, 17 Jan 2026 10:26:02 +0000
From: Weigang He <geoffreyhe2@...il.com>
To: masahiroy@...nel.org
Cc: petr.pavlu@...e.com,
	sam@...nborg.org,
	linux-kernel@...r.kernel.org,
	Weigang He <geoffreyhe2@...il.com>
Subject: [PATCH] genksyms: fix file pointer leaks on error paths

The option parsing loop processes multiple command-line options
sequentially. When -r or -T options successfully open their files,
but a later option causes an early return (e.g., -h for help, an
unknown option, or a failed fopen), the previously opened file
pointers are leaked.

Fix this by closing ref_file and dumpfile before each early return
in the option parsing switch statement.

Fixes: 64e6c1e12372 ("genksyms: track symbol checksum changes")
Signed-off-by: Weigang He <geoffreyhe2@...il.com>
---
 scripts/genksyms/genksyms.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/scripts/genksyms/genksyms.c b/scripts/genksyms/genksyms.c
index 83e48670c2fcf..dee9216797935 100644
--- a/scripts/genksyms/genksyms.c
+++ b/scripts/genksyms/genksyms.c
@@ -776,6 +776,8 @@ int main(int argc, char **argv)
 			ref_file = fopen(optarg, "r");
 			if (!ref_file) {
 				perror(optarg);
+				if (dumpfile)
+					fclose(dumpfile);
 				return 1;
 			}
 			break;
@@ -784,6 +786,8 @@ int main(int argc, char **argv)
 			dumpfile = fopen(optarg, "w");
 			if (!dumpfile) {
 				perror(optarg);
+				if (ref_file)
+					fclose(ref_file);
 				return 1;
 			}
 			break;
@@ -792,9 +796,17 @@ int main(int argc, char **argv)
 			break;
 		case 'h':
 			genksyms_usage();
+			if (ref_file)
+				fclose(ref_file);
+			if (dumpfile)
+				fclose(dumpfile);
 			return 0;
 		default:
 			genksyms_usage();
+			if (ref_file)
+				fclose(ref_file);
+			if (dumpfile)
+				fclose(dumpfile);
 			return 1;
 		}
 	{
-- 
2.34.1