linux-kernel - Re: [PATCH 3/3] spi: dt-bindings: xilinx: make interrupts optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52a9988c-323c-4b2b-be75-896a2db27f94@kernel.org>
Date: Sat, 17 Jan 2026 11:48:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Abdurrahman Hussain <abdurrahman@...thop.ai>,
 Mark Brown <broonie@...nel.org>, Michal Simek <michal.simek@....com>,
 Andrew Lunn <andrew@...n.ch>
Cc: linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] spi: dt-bindings: xilinx: make interrupts optional

On 17/01/2026 00:35, Abdurrahman Hussain wrote:
> This makes the driver work on platforms where interrupts are either not
> provided or broken.

You need to describe the hardware instead. Why interrupts are optional
in the hardware (or are they even?).

> 
> Signed-off-by: Abdurrahman Hussain <abdurrahman@...thop.ai>
> ---
>  Documentation/devicetree/bindings/spi/spi-xilinx.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-xilinx.yaml b/Documentation/devicetree/bindings/spi/spi-xilinx.yaml
> index 4beb3af0416d..8296edde61b0 100644
> --- a/Documentation/devicetree/bindings/spi/spi-xilinx.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-xilinx.yaml
> @@ -23,7 +23,7 @@ properties:
>      maxItems: 1
>  
>    interrupts:
> -    maxItems: 1
> +    maxItems: 1 # optional

Drop comment, pointless. Schema defines that.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

Best regards,
Krzysztof