linux-kernel - Re: [PATCH v4 0/9] Add support for AD4062 device family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260117151232.215213-1-sashal@kernel.org>
Date: Sat, 17 Jan 2026 10:12:32 -0500
From: Sasha Levin <sashal@...nel.org>
To: jic23@...nel.org
Cc: Michael.Hennerich@...log.com,
	andy@...nel.org,
	brgl@...ev.pl,
	conor+dt@...nel.org,
	corbet@....net,
	devicetree@...r.kernel.org,
	dlechner@...libre.com,
	jorge.marques@...log.com,
	krzk+dt@...nel.org,
	lars@...afoo.de,
	linus.walleij@...aro.org,
	linusw@...nel.org,
	linux-doc@...r.kernel.org,
	linux-gpio@...r.kernel.org,
	linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	nuno.sa@...log.com,
	robh@...nel.org
Subject: Re: [PATCH v4 0/9] Add support for AD4062 device family

Hi Jonathan, Jorge,

Heads up: the AD4062 driver uses the deprecated I3C API which was
removed in commit 9904232ae30bc ("i3c: drop i3c_priv_xfer and
i3c_device_do_priv_xfers()"). This causes build failures when
merged with trees containing that commit:

  drivers/iio/adc/ad4062.c:471:24: error: variable 'xfer_trigger' has initializer but incomplete type
    471 |                 struct i3c_priv_xfer xfer_trigger = {
        |                        ^~~~~~~~~~~~~
  drivers/iio/adc/ad4062.c:472:26: error: 'struct i3c_priv_xfer' has no member named 'data'
  ...

The fix is straightforward - migrate to the new API:

  - struct i3c_priv_xfer -> struct i3c_xfer
  - i3c_device_do_priv_xfers(dev, xfers, n) -> i3c_device_do_xfers(dev, xfers, n, I3C_SDR)

The struct fields are identical (i3c_priv_xfer was just a #define
alias), and I3C_SDR is what the old wrapper used internally.

-- 
Thanks,
Sasha