linux-kernel - Re: [PATCH] of: platform: Use default match table for /firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260117011407.GA2286765-robh@kernel.org>
Date: Fri, 16 Jan 2026 19:14:07 -0600
From: Rob Herring <robh@...nel.org>
To: Saravana Kannan <saravanak@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Andy Gross <andy.gross@...aro.org>,
	Sudeep Holla <Sudeep.Holla@....com>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: platform: Use default match table for /firmware

On Tue, Jan 13, 2026 at 07:51:58PM -0600, Rob Herring (Arm) wrote:
> Calling of_platform_populate() without a match table will only populate
> the immediate child nodes under /firmware. This is usually fine, but in
> the case of something like a "simple-mfd" node such as
> "raspberrypi,bcm2835-firmware", those child nodes will not be populated.
> And subsequent calls won't work either because the /firmware node is
> marked as processed already.
> 
> Switch the call to of_platform_default_populate() to solve this problem.
> It should be a nop for existing cases.
> 
> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
> Cc: stable@...r.kernel.org
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  drivers/of/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index d4e169b3b5af..d90b1677d84e 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -568,7 +568,7 @@ static int __init of_platform_default_populate_init(void)
>  
>  		node = of_find_node_by_path("/firmware");
>  		if (node) {
> -			of_platform_populate(node, NULL, NULL, NULL);
> +			of_platform_default_populate(node, NULL, NULL);
>  			of_node_put(node);
>  		}
>  
> -- 
> 2.51.0
>