linux-kernel - Re: [PATCH] thermal/of: fix device node refcount leak in thermal_of_cm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eaf05847-b5c0-44b7-a619-7119d569df17@web.de>
Date: Sat, 17 Jan 2026 17:20:41 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Weigang He <geoffreyhe2@...il.com>, linux-pm@...r.kernel.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 kernel-janitors@...r.kernel.org, Daniel Lezcano <daniel.lezcano@...aro.org>,
 Lukasz Luba <lukasz.luba@....com>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH] thermal/of: fix device node refcount leak in
 thermal_of_cm_lookup()

…
> Add the missing of_node_put() calls on all paths to prevent the

How do you think about to use an attribute like “__free(device_node)” instead?
https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/of.h#L138
https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/thermal/thermal_of.c#L277-L303

Was such an improvable implementation detail detected by any known source code
analysis approaches?

> reference count leak.

Would you like to use this term also in the summary phrase?

Regards,
Markus