linux-kernel - Re: [PATCH net v2] net: stmmac: fix transmit queue timed out after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260117090634.26148eb4@kernel.org>
Date: Sat, 17 Jan 2026 09:06:34 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>, Tao Wang
 <tao03.wang@...izon.auto>, alexandre.torgue@...s.st.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 horms@...nel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 mcoquelin.stm32@...il.com, netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net v2] net: stmmac: fix transmit queue timed out after
 resume

On Fri, 16 Jan 2026 20:57:05 +0000 Russell King (Oracle) wrote:
> Thoughts - should the kernel default to having flow control enabled
> or disabled in light of this? Should this feature require explicit
> administrative configuration given the severity of network disruption?

FWIW in DC historically we have seen a few NICs which have tiny buffers
so back-pressuring up to the top of rack switch is helpful. Switches
have more reasonable buffers. That's just NIC Tx pause, switch Rx pause
(from downlink ports, not fabric!). Letting switches generate pause is 
a recipe for.. not having a network. We'd need to figure out why Netgear
does what it does in your case, IMHO.