linux-kernel - Re: [PATCH] memory: emif: fix device tree node reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a06549ab-e6cc-4bc4-b161-f6fcb92721df@kernel.org>
Date: Sat, 17 Jan 2026 18:51:47 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Weigang He <geoffreyhe2@...il.com>,
 Santosh Shilimkar <ssantosh@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory: emif: fix device tree node reference leak

On 15/01/2026 07:42, Weigang He wrote:
> The EMIF driver acquires a device tree node reference via
> of_parse_phandle() but never releases it with of_node_put(),
> causing a reference count leak.
> 
> This affects:
> 1. Error paths in of_get_memory_device_details() - if allocation
>    or validation fails after of_parse_phandle() succeeds, the
>    reference is leaked
> 2. Normal driver removal - emif_remove() never releases the
>    reference stored in emif->np_ddr
> 
> Fix by adding an err_put_node label to properly release the node
> reference on error paths, and adding of_node_put() in emif_remove()
> to release the reference during normal driver unload.
> 
> Fixes: e6b42eb6a66c ("memory: emif: add device tree support to emif driver")

Missing Cc stable.

> Signed-off-by: Weigang He <geoffreyhe2@...il.com>
> ---
>  drivers/memory/emif.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
> index 2fadad0666b1f..e4f7547efbff4 100644
> --- a/drivers/memory/emif.c
> +++ b/drivers/memory/emif.c
> @@ -922,7 +922,7 @@ static struct emif_data *of_get_memory_device_details(
>  	if (!emif || !pd || !dev_info) {
>  		dev_err(dev, "%s: Out of memory!!\n",
>  			__func__);
> -		goto error;
> +		goto err_put_node;
>  	}
>  
>  	emif->plat_data		= pd;
> @@ -946,7 +946,7 @@ static struct emif_data *of_get_memory_device_details(
>  			pd->device_info->io_width, pd->phy_type, pd->ip_rev,
>  			emif->dev)) {
>  		dev_err(dev, "%s: invalid device data!!\n", __func__);
> -		goto error;
> +		goto err_put_node;
>  	}
>  	/*
>  	 * For EMIF instances other than EMIF1 see if the devices connected
> @@ -970,6 +970,8 @@ static struct emif_data *of_get_memory_device_details(
>  	emif->plat_data->min_tck = of_get_min_tck(np_ddr, emif->dev);
>  	goto out;
>  
> +err_put_node:
> +	of_node_put(np_ddr);
>  error:

This is unused now. You do not need new label, just use existing one.


Best regards,
Krzysztof