linux-kernel - Re: [PATCH 2/4] x86/vdso: Use 32-bit CHECKFLAGS for compat vDSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bjir3nfy.ffs@tglx>
Date: Sat, 17 Jan 2026 23:05:05 +0100
From: Thomas Gleixner <tglx@...nel.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 "David S. Miller"
 <davem@...emloft.net>, Andreas Larsson <andreas@...sler.com>, Andy
 Lutomirski <luto@...nel.org>, Ingo Molnar <mingo@...hat.com>, Borislav
 Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, Arnd Bergmann
 <arnd@...db.de>, Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik
 <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>, Christian
 Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle
 <svens@...ux.ibm.com>
Cc: sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arch@...r.kernel.org, linux-s390@...r.kernel.org, Thomas
 Weißschuh
 <thomas.weissschuh@...utronix.de>, Sun Jian <sun.jian.kdev@...il.com>
Subject: Re: [PATCH 2/4] x86/vdso: Use 32-bit CHECKFLAGS for compat vDSO

On Fri, Jan 16 2026 at 08:40, Thomas Weißschuh wrote:
> Manually override the CHECKFLAGS for the compat vDSO with the correct
> 32-bit configuration.

Fun. I just fixed the same thing half an hour ago:

   https://lore.kernel.org/lkml/20260117215542.342638347@kernel.org/

> Reported-by: Sun Jian <sun.jian.kdev@...il.com>
> Closes: https://lore.kernel.org/lkml/20260114084529.1676356-1-sun.jian.kdev@gmail.com/
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
>  arch/x86/entry/vdso/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
> index f247f5f5cb44..ab571ad9b9ac 100644
> --- a/arch/x86/entry/vdso/Makefile
> +++ b/arch/x86/entry/vdso/Makefile
> @@ -142,7 +142,10 @@ ifneq ($(RETPOLINE_VDSO_CFLAGS),)
>  endif
>  endif
>  
> +CHECKFLAGS_32 := $(CHECKFLAGS) -U__x86_64__ -D__i386__ -m32

Hmm. That keeps -m64. Seems not to matter much, but substituting both
seems to be more correct.

Thanks,

        tglx