linux-kernel - Re: [PATCH v4 7/7] mmc: host: renesas_sdhi_core: support selecting an optional mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0eede154-9769-41fa-8cdd-a9591c147b58@solid-run.com>
Date: Sun, 18 Jan 2026 07:33:51 +0000
From: Josua Mayer <josua@...id-run.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
CC: Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm
	<magnus.damm@...il.com>, Marc Kleine-Budde <mkl@...gutronix.de>, Vincent
 Mailhol <mailhol@...nel.org>, Vinod Koul <vkoul@...nel.org>, Kishon Vijay
 Abraham I <kishon@...nel.org>, Peter Rosin <peda@...ntia.se>, Aaro Koskinen
	<aaro.koskinen@....fi>, Andreas Kemnade <andreas@...nade.info>, Kevin Hilman
	<khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, Tony Lindgren
	<tony@...mide.com>, Vignesh R <vigneshr@...com>, Janusz Krzysztofik
	<jmkrzyszt@...il.com>, Andi Shyti <andi.shyti@...nel.org>, Neil Armstrong
	<neil.armstrong@...aro.org>, Mikhail Anikin <mikhail.anikin@...id-run.com>,
	Yazan Shhady <yazan.shhady@...id-run.com>, Jon Nettleton <jon@...id-run.com>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v4 7/7] mmc: host: renesas_sdhi_core: support selecting an
 optional mux

Hi Wolfram,

On 14/01/2026 13:49, Wolfram Sang wrote:
> Hi Josua,
>
> thanks for your work and kudos for striving for a generic solution. It
> seems worthwhile to me to add the helpers. I have questions, though:
>
>> +	priv->mux_state = devm_mux_state_get_optional_selected(&pdev->dev, NULL);
> The minor nit (which may be bike-shedding): Maybe the function name
> could be '*_select' instead of '*_selected'. To make more explicit that
> this function is actively changing the selection and not passively
> retrieving the current state?
I have no strong opinion on select vs. selected.
I merely followed the devm_clk_get_enabled/selected.
>
> The bigger thing is that with devm_* I had the expectation that
> deselection is also handled automatically...
>
>> +edselmux:
>> +	if (priv->mux_state)
>> +		mux_state_deselect(priv->mux_state);
> ... so I was a bit surprised to see this manual cleanup. Has it been
> discussed if that deselection can also be in the helpers?
I have not considered adding this, and was careful
not to imply it in the function descriptions.

At the time I felt adding helpers was growing in complexity too fast,
and I am not very familair with devres.

I agree that the general expectation is devm functions are fully managed,
in this case including deselect.

>
> Happy hacking,
>
>     Wolfram
>
>
sincerely
Josua Mayer