linux-kernel - [PATCH] irqchip/aslint-sswi: fix error checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260118082843.2786630-1-vladimir.kondratiev@mobileye.com>
Date: Sun, 18 Jan 2026 10:28:43 +0200
From: Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>
To: tglx@...nel.org
Cc: clm@...a.com,
	linux-kernel@...r.kernel.org,
	luxu.kernel@...edance.com,
	vladimir.kondratiev@...ileye.com
Subject: [PATCH] irqchip/aslint-sswi: fix error checking

of_io_request_and_map() returns IOMEM_ERR_PTR() on failure which is
non-NULL.

Signed-off-by: Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>
---
 drivers/irqchip/irq-aclint-sswi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-aclint-sswi.c b/drivers/irqchip/irq-aclint-sswi.c
index 325501f34a9b..ca06efd86fa1 100644
--- a/drivers/irqchip/irq-aclint-sswi.c
+++ b/drivers/irqchip/irq-aclint-sswi.c
@@ -110,8 +110,10 @@ static int __init aclint_sswi_probe(struct fwnode_handle *fwnode)
 		return -EINVAL;
 
 	reg = of_io_request_and_map(to_of_node(fwnode), 0, NULL);
-	if (!reg)
-		return -ENOMEM;
+	if (IS_ERR(reg)) {
+		pr_err("%pfwP: Failed to map MMIO region\n", fwnode);
+		return PTR_ERR(reg);
+	}
 
 	/* Parse SSWI setting */
 	rc = aclint_sswi_parse_irq(fwnode, reg);
-- 
2.43.0