linux-kernel - Re: [PATCH v2 3/7] dt-bindings: sound: sophgo: add CV1800B internal ADC codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260118-literate-tan-sheep-33bdf3@quoll>
Date: Sun, 18 Jan 2026 11:15:25 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Anton D. Stavinskii" <stavinsky@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>, 
	Inochi Amaoto <inochiama@...il.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, linux-sound@...r.kernel.org, 
	devicetree@...r.kernel.org, sophgo@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 3/7] dt-bindings: sound: sophgo: add CV1800B internal
 ADC codec

On Sun, Jan 18, 2026 at 12:18:55AM +0400, Anton D. Stavinskii wrote:
> Document the internal ADC audio codec integrated in the Sophgo
> CV1800B SoC.
> 
> Signed-off-by: Anton D. Stavinskii <stavinsky@...il.com>
> ---
>  .../bindings/sound/sophgo,cv1800b-sound-adc.yaml   | 43 ++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/sophgo,cv1800b-sound-adc.yaml b/Documentation/devicetree/bindings/sound/sophgo,cv1800b-sound-adc.yaml
> new file mode 100644
> index 000000000000..339b60e317e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/sophgo,cv1800b-sound-adc.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/sophgo,cv1800b-sound-adc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sophgo CV1800B Internal ADC Codec
> +
> +maintainers:
> +  - Anton D. Stavinskii <stavinsky@...il.com>
> +
> +description: |

Same comments as for first bindings patch.

All of them.


> +  Internal ADC audio codec integrated in the Sophgo CV1800B SoC.
> +  The codec exposes a single DAI and is intended to be connected
> +  to an I2S/TDM controller via an ASoC machine driver.
> +
> +properties:
> +  compatible:
> +    const: sophgo,cv1800b-sound-adc
> +
> +  reg:
> +    maxItems: 1
> +    description:
> +      Base address and size of the ADC register block.

Drop description, redundant.

> +
> +  "#sound-dai-cells":
> +    const: 0

Best regards,
Krzysztof