lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20260118-mprl_driver_followup-v1-1-5d5d6b03350b@subdimension.ro>
Date: Sun, 18 Jan 2026 13:19:39 +0200
From: Petre Rodan <petre.rodan@...dimension.ro>
To: Andreas Klinger <ak@...klinger.de>, Jonathan Cameron <jic23@...nel.org>, 
 David Lechner <dlechner@...libre.com>, 
 Nuno Sá <nuno.sa@...log.com>, 
 Andy Shevchenko <andy@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] iio: pressure: mprls0025pa: remove error message

Do not print a duplicate error message if devm_request_irq() fails.

Signed-off-by: Petre Rodan <petre.rodan@...dimension.ro>
---
A tiny followup to the mprls driver cleanup, as requested by Andy [1]

This patch is against testing, since at the time of my pull the
cleanup was not present in the togreg branch. I hope it's fine.

best regards,
peter

Link: https://lore.kernel.org/linux-iio/20260116190153.082b9cc0@jic23-huawei/T/#mbf1be48fe2bc58c0c065f8598e80d623326976f3 [1]
---
 drivers/iio/pressure/mprls0025pa.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/pressure/mprls0025pa.c b/drivers/iio/pressure/mprls0025pa.c
index 587d0dcad89b..e8c495f336ff 100644
--- a/drivers/iio/pressure/mprls0025pa.c
+++ b/drivers/iio/pressure/mprls0025pa.c
@@ -413,8 +413,7 @@ int mpr_common_probe(struct device *dev, const struct mpr_ops *ops, int irq)
 		ret = devm_request_irq(dev, data->irq, mpr_eoc_handler, 0,
 				       dev_name(dev), data);
 		if (ret)
-			return dev_err_probe(dev, ret,
-					  "request irq %d failed\n", data->irq);
+			return ret;
 	}
 
 	data->gpiod_reset = devm_gpiod_get_optional(dev, "reset",

---
base-commit: c30e80d68a7afb334fde7147ee0106f25dd58d3a
change-id: 20260118-mprl_driver_followup-bdab25d42ccd

Best regards,
-- 
Petre Rodan <petre.rodan@...dimension.ro>


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ