linux-kernel - Re: [PATCH 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWzLv5ezJOf5r8Rl@stanley.mountain>
Date: Sun, 18 Jan 2026 15:02:07 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Khushal Chitturi <khushalchitturi@...il.com>
Cc: gregkh@...uxfoundation.org, hansg@...nel.org, straube.linux@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] staging: rtl8723bs: rename CamelCase identifiers to
 snake_case

On Thu, Jan 15, 2026 at 03:59:09PM +0530, Khushal Chitturi wrote:
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index ef2d92b5588a..005e6737e1af 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1148,10 +1148,11 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
>  			BusyThreshold = BusyThresholdLow;
>  
>  		if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold ||
> -			pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) {
> +			pmlmepriv->LinkDetectInfo.tx_ok_in_period > BusyThreshold) {
>  			bBusyTraffic = true;
>  
> -			if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectInfo.NumTxOkInPeriod)
> +			if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod >
> +			    pmlmepriv->LinkDetectInfo.tx_ok_in_period)

This is just weird now.  NumRxOkInPeriod vs tx_ok_in_period?  The names
don't match and the tx_ok_in_period name doesn't make sense.

regards,
dan carpenter