linux-kernel - Re: [PATCH v3 1/2] power: supply: Add macsmc-power driver for Apple Silicon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANpmGNvNe-Y7mgMEqKYGvyA-v6pKLc_9NZ8LBLuy7__F+k4oGg@mail.gmail.com>
Date: Sun, 18 Jan 2026 23:53:44 +1100
From: Michael Reeves <michael.reeves077@...il.com>
To: Sven Peter <sven@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, 
	asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	Hector Martin <marcan@...can.st>, Lee Jones <lee@...nel.org>, Neal Gompa <neal@...pa.dev>, 
	Janne Grunau <j@...nau.net>, Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH v3 1/2] power: supply: Add macsmc-power driver for Apple Silicon

Hi Sven,

Thank you so much for looking into this!

On Fri, Jan 16, 2026 at 8:00 AM Sven Peter <sven@...nel.org> wrote:
[...]
> > +
> > +static int macsmc_power_event(struct notifier_block *nb, unsigned long event, void *data)
> > +{
> > +     struct macsmc_power *power = container_of(nb, struct macsmc_power, nb);
> > +
> > +     /*
> > +      * SMC Event IDs are reverse-engineered.
>
> Any chance you meant something else here? The event IDs aren't special,
> everything here is reverse-engineered ;)
I was more meaning that they are made by correlating when certain
event IDs appear,
so the comments I've added aren't 100% certain as what Apple intended
for each ID,
(unlike keys where we can be more certain because they report a
physical value).
I guess that wasn't the best choice of words as everything is RE'ed,
as you've said.
In v4 I'll make this clearer, thank you for the pickup.

Best regards,
Michael