linux-kernel - Re: [PATCH v3 2/2] mfd: macsmc: Wire up Apple SMC power driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANpmGNuZjYVEu-0mGezuy0mLpnu9Cg1aBooJV=hAr+-BJW0yiw@mail.gmail.com>
Date: Mon, 19 Jan 2026 00:01:03 +1100
From: Michael Reeves <michael.reeves077@...il.com>
To: Janne Grunau <j@...nau.net>
Cc: Sebastian Reichel <sre@...nel.org>, Sven Peter <sven@...nel.org>, Neal Gompa <neal@...pa.dev>, 
	Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, 
	asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	Hector Martin <marcan@...can.st>
Subject: Re: [PATCH v3 2/2] mfd: macsmc: Wire up Apple SMC power driver

Hi Janne,

Thank you again for your feedback!

On Sat, Jan 17, 2026 at 11:32 PM Janne Grunau <j@...nau.net> wrote:
>
> On Thu, Jan 15, 2026 at 06:08:16PM +1100, Michael Reeves via B4 Relay wrote:
> > From: Michael Reeves <michael.reeves077@...il.com>
> >
> > Add the cell for the macsmc-power driver so it is probed by the
> > MFD core.
> >
> > Co-developed-by: Hector Martin <marcan@...can.st>
> > Signed-off-by: Hector Martin <marcan@...can.st>
>
> Co-developed-by: for a single line change as simple as this is silly.
> Please just keep Hector as author and just add your SOB
>
Will fix in v4, thanks for pointing it out!
> > Reviewed-by: Neal Gompa <neal@...pa.dev>
> > Signed-off-by: Michael Reeves <michael.reeves077@...il.com>
> > ---
> >  drivers/mfd/macsmc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/macsmc.c b/drivers/mfd/macsmc.c
> > index 1b7e7b3e785f..358feec2d088 100644
> > --- a/drivers/mfd/macsmc.c
> > +++ b/drivers/mfd/macsmc.c
> > @@ -46,6 +46,7 @@
> >
> >  static const struct mfd_cell apple_smc_devs[] = {
> >       MFD_CELL_NAME("macsmc-input"),
> > +     MFD_CELL_NAME("macsmc-power"),
> >       MFD_CELL_OF("macsmc-gpio", NULL, NULL, 0, 0, "apple,smc-gpio"),
> >       MFD_CELL_OF("macsmc-hwmon", NULL, NULL, 0, 0, "apple,smc-hwmon"),
> >       MFD_CELL_OF("macsmc-reboot", NULL, NULL, 0, 0, "apple,smc-reboot"),
>
> This patch does not apply on top of v6.19-rc1. The base-commit helpfully
> provided by b4 does not exists in my tree. I assume it's either a mfd or
> linux-next commit? Please note the branch/tag this series applies to in
> the cover letter if it is not the most recent -rc1 from Linus
>
It's based on-top of the latest linux-next, I will mention this in the
cover letter
body for v4 (i only put it in 'Changes in v3' for this one), thank you for the
pickup!
> Janne

Thank you again!

Best regards,
Michael