linux-kernel - Re: [PATCH v6 1/3] sched/fair: Co-locate cfs_rq and sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADsDNuWrJxRtC0bwRyCq0TjEW+1isWwc4gaigwC0yMRa5wwYVA@mail.gmail.com>
Date: Sat, 17 Jan 2026 20:49:20 -0500
From: Zecheng Li <zli94@...u.edu>
To: Josh Don <joshdon@...gle.com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
	Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>, 
	Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, 
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, 
	Valentin Schneider <vschneid@...hat.com>, Rik van Riel <riel@...riel.com>, Chris Mason <clm@...com>, 
	Madadi Vineeth Reddy <vineethr@...ux.ibm.com>, Xu Liu <xliuprof@...gle.com>, 
	Blake Jones <blakejones@...gle.com>, Nilay Vaish <nilayvaish@...gle.com>, 
	linux-kernel@...r.kernel.org, Zecheng Li <zecheng@...gle.com>
Subject: Re: [PATCH v6 1/3] sched/fair: Co-locate cfs_rq and sched_entity

Hi Josh,

Thanks for the review.

On Thu, Jan 15, 2026 at 7:48 PM Josh Don <joshdon@...gle.com> wrote:
>
> Now that we have a general purpose container struct (cfs_rq_with_se),
> I wonder if it makes more sense to get rid of sched_entity_stats and
> directly embed se and stats in cfs_rq_with_se.

Yes, that makes sense. I'll remove sched_entity_stats and embed
cfs_rq, sched_entity and stats in the container struct for v7.

> > +
> > +struct cfs_rq_with_se {
> > +       struct cfs_rq                   cfs_rq;
> > +       struct sched_entity_stats       ses;
> > +};
> > +#endif
>
> nit: The struct name feels a bit awkward, perhaps something like tg_cfs_state?
>

Sure. I'm thinking cfs_tg_state to keep consistent with the cfs_
prefix used elsewhere in the fair scheduler.