linux-kernel - Re: [PATCH v6] rust: iommu: add io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFRSME7WFXY0.2XQSN0VXMI9MD@kernel.org>
Date: Sun, 18 Jan 2026 15:43:11 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Alice Ryhl" <aliceryhl@...gle.com>
Cc: "Joerg Roedel" <joro@...tes.org>, "Miguel Ojeda" <ojeda@...nel.org>,
 "Will Deacon" <will@...nel.org>, "Daniel Almeida"
 <daniel.almeida@...labora.com>, "Boris Brezillon"
 <boris.brezillon@...labora.com>, "Robin Murphy" <robin.murphy@....com>,
 "Jason Gunthorpe" <jgg@...pe.ca>, "Boqun Feng" <boqun.feng@...il.com>,
 "Gary Guo" <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Trevor Gross" <tmgross@...ch.edu>,
 "Lorenzo Stoakes" <lorenzo.stoakes@...cle.com>, "Liam R. Howlett"
 <Liam.Howlett@...cle.com>, "Asahi Lina" <lina+kernel@...hilina.net>,
 <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>,
 <iommu@...ts.linux.dev>, <linux-mm@...ck.org>, "Deborah Brouwer"
 <deborah.brouwer@...labora.com>
Subject: Re: [PATCH v6] rust: iommu: add io_pgtable abstraction

On Sun Jan 18, 2026 at 11:08 AM CET, Alice Ryhl wrote:
> +use crate::{
> +    alloc,
> +    bindings,
> +    device::{Bound, Device},

NIT: Wrong style.

@Joerg: Maybe you can fix it up when applying the patch, it should look like
this:

	use crate::{
	    alloc,
	    bindings,
	    device::{
	        Bound,
	        Device, //
	    },
	    devres::Devres,
	    error::to_result,
	    io::PhysAddr,
	    prelude::*, //
	};

Otherwise, looks good to me,

Reviewed-by: Danilo Krummrich <dakr@...nel.org>