linux-kernel - Re: [PATCH v4 3/3] of: Respect #{iommu,msi}-cells in maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aec4a691-03c5-46ec-b99a-6b68a2bcedf4@oss.qualcomm.com>
Date: Sun, 18 Jan 2026 23:45:38 +0530
From: Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, robin.murphy@....com,
        will@...nel.org, joro@...tes.org, robh@...nel.org,
        dmitry.baryshkov@....qualcomm.com, bjorn.andersson@....qualcomm.com,
        bod@...nel.org, conor+dt@...nel.org, krzk+dt@...nel.org,
        saravanak@...gle.com, prakash.gupta@....qualcomm.com,
        vikash.garodia@....qualcomm.com
Cc: iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 3/3] of: Respect #{iommu,msi}-cells in maps



On 1/7/2026 4:30 PM, Konrad Dybcio wrote:
> On 1/7/26 6:31 AM, Vijayanand Jitta wrote:
>>
>>
>> On 12/31/2025 5:12 PM, Vijayanand Jitta wrote:
>>> From: Robin Murphy <robin.murphy@....com>
>>>
>>> So far our parsing of {iommu,msi}-map properites has always blindly
>>> asusmed that the output specifiers will always have exactly 1 cell.
>>> This typically does happen to be the case, but is not actually enforced
>>> (and the PCI msi-map binding even explicitly states support for 0 or 1
>>> cells) - as a result we've now ended up with dodgy DTs out in the field
>>> which depend on this behaviour to map a 1-cell specifier for a 2-cell
>>> provider, despite that being bogus per the bindings themselves.
>>>
>>> Since there is some potential use in being able to map at least single
>>> input IDs to multi-cell output specifiers (and properly support 0-cell
>>> outputs as well), add support for properly parsing and using the target
>>> nodes' #cells values, albeit with the unfortunate complication of still
>>> having to work around expectations of the old behaviour too.
>>>
>>> Since there are multi-cell output specifiers, the callers of of_map_id()
>>> may need to get the exact cell output value for further processing.
>>> Added support for that part --charan
>>>
>>> Signed-off-by: Robin Murphy <robin.murphy@....com>
>>> Signed-off-by: Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>
>>> ---
> 
> [...]
> 
>> Rob, 
>>
>> Gentle ping, could you please let me know if the latest patchset looks good enough
>> to be considered for the next merge window?
> 
> You have an outstanding build warning:
> 
> <202601062128.BCmw1wNO-lkp@...el.com>
> 
> Konrad


Thanks, I have fixed those and sent out V5. Please review.

Thanks,
Vijay