| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202601190121.z9C0uml5-lkp@intel.com>
Date: Sun, 18 Jan 2026 22:25:29 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev, Prike Liang <Prike.Liang@....com>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org,
Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>
Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:804
amdgpu_gmc_flush_gpu_tlb_pasid() warn: inconsistent returns
'&adev->reset_domain->sem'.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e84d960149e71e8d5e4db69775ce31305898ed0c
commit: 0bea77b13b7649710108e6b67937ab4c7f8a9363 drm/amdgpu: validate the flush_gpu_tlb_pasid()
config: powerpc64-randconfig-r071-20260118 (https://download.01.org/0day-ci/archive/20260119/202601190121.z9C0uml5-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
smatch version: v0.5.0-8985-g2614ff1a
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202601190121.z9C0uml5-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:804 amdgpu_gmc_flush_gpu_tlb_pasid() warn: inconsistent returns '&adev->reset_domain->sem'.
vim +804 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
e7b90e99fa8fd6 Christian König 2023-09-04 717 int amdgpu_gmc_flush_gpu_tlb_pasid(struct amdgpu_device *adev, uint16_t pasid,
e7b90e99fa8fd6 Christian König 2023-09-04 718 uint32_t flush_type, bool all_hub,
e7b90e99fa8fd6 Christian König 2023-09-04 719 uint32_t inst)
e7b90e99fa8fd6 Christian König 2023-09-04 720 {
e7b90e99fa8fd6 Christian König 2023-09-04 721 struct amdgpu_ring *ring = &adev->gfx.kiq[inst].ring;
e7b90e99fa8fd6 Christian König 2023-09-04 722 struct amdgpu_kiq *kiq = &adev->gfx.kiq[inst];
e7b90e99fa8fd6 Christian König 2023-09-04 723 unsigned int ndw;
3666ed821832f4 Jay Cornwall 2025-03-21 724 int r, cnt = 0;
e7b90e99fa8fd6 Christian König 2023-09-04 725 uint32_t seq;
e7b90e99fa8fd6 Christian König 2023-09-04 726
9c33e5fd4fb63b Yunxiang Li 2024-05-23 727 /*
9c33e5fd4fb63b Yunxiang Li 2024-05-23 728 * A GPU reset should flush all TLBs anyway, so no need to do
9c33e5fd4fb63b Yunxiang Li 2024-05-23 729 * this while one is ongoing.
9c33e5fd4fb63b Yunxiang Li 2024-05-23 730 */
9c33e5fd4fb63b Yunxiang Li 2024-05-23 731 if (!down_read_trylock(&adev->reset_domain->sem))
9c33e5fd4fb63b Yunxiang Li 2024-05-23 732 return 0;
08abccc9a7a7ff Christian König 2023-09-04 733
9c33e5fd4fb63b Yunxiang Li 2024-05-23 734 if (!adev->gmc.flush_pasid_uses_kiq || !ring->sched.ready) {
0bea77b13b7649 Prike Liang 2026-01-06 735
0bea77b13b7649 Prike Liang 2026-01-06 736 if (!adev->gmc.gmc_funcs->flush_gpu_tlb_pasid)
0bea77b13b7649 Prike Liang 2026-01-06 737 return 0;
need to call up_read(&adev->reset_domain->sem) before returning.
0bea77b13b7649 Prike Liang 2026-01-06 738
08abccc9a7a7ff Christian König 2023-09-04 739 if (adev->gmc.flush_tlb_needs_extra_type_2)
08abccc9a7a7ff Christian König 2023-09-04 740 adev->gmc.gmc_funcs->flush_gpu_tlb_pasid(adev, pasid,
08abccc9a7a7ff Christian König 2023-09-04 741 2, all_hub,
08abccc9a7a7ff Christian König 2023-09-04 742 inst);
08abccc9a7a7ff Christian König 2023-09-04 743
08abccc9a7a7ff Christian König 2023-09-04 744 if (adev->gmc.flush_tlb_needs_extra_type_0 && flush_type == 2)
08abccc9a7a7ff Christian König 2023-09-04 745 adev->gmc.gmc_funcs->flush_gpu_tlb_pasid(adev, pasid,
08abccc9a7a7ff Christian König 2023-09-04 746 0, all_hub,
08abccc9a7a7ff Christian König 2023-09-04 747 inst);
08abccc9a7a7ff Christian König 2023-09-04 748
3983c9fd2d8b5a Christian König 2023-09-04 749 adev->gmc.gmc_funcs->flush_gpu_tlb_pasid(adev, pasid,
3983c9fd2d8b5a Christian König 2023-09-04 750 flush_type, all_hub,
3983c9fd2d8b5a Christian König 2023-09-04 751 inst);
9c33e5fd4fb63b Yunxiang Li 2024-05-23 752 r = 0;
9c33e5fd4fb63b Yunxiang Li 2024-05-23 753 } else {
e7b90e99fa8fd6 Christian König 2023-09-04 754 /* 2 dwords flush + 8 dwords fence */
e7b90e99fa8fd6 Christian König 2023-09-04 755 ndw = kiq->pmf->invalidate_tlbs_size + 8;
e7b90e99fa8fd6 Christian König 2023-09-04 756
e7b90e99fa8fd6 Christian König 2023-09-04 757 if (adev->gmc.flush_tlb_needs_extra_type_2)
e7b90e99fa8fd6 Christian König 2023-09-04 758 ndw += kiq->pmf->invalidate_tlbs_size;
e7b90e99fa8fd6 Christian König 2023-09-04 759
e7b90e99fa8fd6 Christian König 2023-09-04 760 if (adev->gmc.flush_tlb_needs_extra_type_0)
e7b90e99fa8fd6 Christian König 2023-09-04 761 ndw += kiq->pmf->invalidate_tlbs_size;
e7b90e99fa8fd6 Christian König 2023-09-04 762
e7b90e99fa8fd6 Christian König 2023-09-04 763 spin_lock(&adev->gfx.kiq[inst].ring_lock);
9ff2e14cf013fa Bob Zhou 2024-06-20 764 r = amdgpu_ring_alloc(ring, ndw);
9ff2e14cf013fa Bob Zhou 2024-06-20 765 if (r) {
9ff2e14cf013fa Bob Zhou 2024-06-20 766 spin_unlock(&adev->gfx.kiq[inst].ring_lock);
9ff2e14cf013fa Bob Zhou 2024-06-20 767 goto error_unlock_reset;
9ff2e14cf013fa Bob Zhou 2024-06-20 768 }
e7b90e99fa8fd6 Christian König 2023-09-04 769 if (adev->gmc.flush_tlb_needs_extra_type_2)
e7b90e99fa8fd6 Christian König 2023-09-04 770 kiq->pmf->kiq_invalidate_tlbs(ring, pasid, 2, all_hub);
e7b90e99fa8fd6 Christian König 2023-09-04 771
e7b90e99fa8fd6 Christian König 2023-09-04 772 if (flush_type == 2 && adev->gmc.flush_tlb_needs_extra_type_0)
e7b90e99fa8fd6 Christian König 2023-09-04 773 kiq->pmf->kiq_invalidate_tlbs(ring, pasid, 0, all_hub);
e7b90e99fa8fd6 Christian König 2023-09-04 774
e7b90e99fa8fd6 Christian König 2023-09-04 775 kiq->pmf->kiq_invalidate_tlbs(ring, pasid, flush_type, all_hub);
e7b90e99fa8fd6 Christian König 2023-09-04 776 r = amdgpu_fence_emit_polling(ring, &seq, MAX_KIQ_REG_WAIT);
e7b90e99fa8fd6 Christian König 2023-09-04 777 if (r) {
e7b90e99fa8fd6 Christian König 2023-09-04 778 amdgpu_ring_undo(ring);
e7b90e99fa8fd6 Christian König 2023-09-04 779 spin_unlock(&adev->gfx.kiq[inst].ring_lock);
e7b90e99fa8fd6 Christian König 2023-09-04 780 goto error_unlock_reset;
e7b90e99fa8fd6 Christian König 2023-09-04 781 }
e7b90e99fa8fd6 Christian König 2023-09-04 782
e7b90e99fa8fd6 Christian König 2023-09-04 783 amdgpu_ring_commit(ring);
e7b90e99fa8fd6 Christian König 2023-09-04 784 spin_unlock(&adev->gfx.kiq[inst].ring_lock);
3666ed821832f4 Jay Cornwall 2025-03-21 785
3666ed821832f4 Jay Cornwall 2025-03-21 786 r = amdgpu_fence_wait_polling(ring, seq, MAX_KIQ_REG_WAIT);
3666ed821832f4 Jay Cornwall 2025-03-21 787
3666ed821832f4 Jay Cornwall 2025-03-21 788 might_sleep();
3666ed821832f4 Jay Cornwall 2025-03-21 789 while (r < 1 && cnt++ < MAX_KIQ_REG_TRY &&
3666ed821832f4 Jay Cornwall 2025-03-21 790 !amdgpu_reset_pending(adev->reset_domain)) {
3666ed821832f4 Jay Cornwall 2025-03-21 791 msleep(MAX_KIQ_REG_BAILOUT_INTERVAL);
3666ed821832f4 Jay Cornwall 2025-03-21 792 r = amdgpu_fence_wait_polling(ring, seq, MAX_KIQ_REG_WAIT);
3666ed821832f4 Jay Cornwall 2025-03-21 793 }
3666ed821832f4 Jay Cornwall 2025-03-21 794
3666ed821832f4 Jay Cornwall 2025-03-21 795 if (cnt > MAX_KIQ_REG_TRY) {
9c33e5fd4fb63b Yunxiang Li 2024-05-23 796 dev_err(adev->dev, "timeout waiting for kiq fence\n");
e7b90e99fa8fd6 Christian König 2023-09-04 797 r = -ETIME;
3666ed821832f4 Jay Cornwall 2025-03-21 798 } else
3666ed821832f4 Jay Cornwall 2025-03-21 799 r = 0;
9c33e5fd4fb63b Yunxiang Li 2024-05-23 800 }
e7b90e99fa8fd6 Christian König 2023-09-04 801
e7b90e99fa8fd6 Christian König 2023-09-04 802 error_unlock_reset:
e7b90e99fa8fd6 Christian König 2023-09-04 803 up_read(&adev->reset_domain->sem);
e7b90e99fa8fd6 Christian König 2023-09-04 @804 return r;
e7b90e99fa8fd6 Christian König 2023-09-04 805 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists