linux-kernel - Re: [PATCH 2/2] mailbox: zynqmp-ipi: Simplify with scoped for each OF child loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABb+yY3O7pqswS16qJx-Ud_HHxdkboRDWy4qBitd59wM_O31tg@mail.gmail.com>
Date: Sun, 18 Jan 2026 14:51:39 -0600
From: Jassi Brar <jassisinghbrar@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Michal Simek <michal.simek@....com>, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 2/2] mailbox: zynqmp-ipi: Simplify with scoped for each OF
 child loop

On Wed, Dec 24, 2025 at 5:45 AM Krzysztof Kozlowski
<krzysztof.kozlowski@....qualcomm.com> wrote:
>
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> ---
>  drivers/mailbox/zynqmp-ipi-mailbox.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 967967b2b8a9..42d2583e44ca 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -904,7 +904,7 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_pdata *pdata)
>  static int zynqmp_ipi_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
> -       struct device_node *nc, *np = pdev->dev.of_node;
> +       struct device_node *np = pdev->dev.of_node;
>         struct zynqmp_ipi_pdata *pdata;
>         struct of_phandle_args out_irq;
>         struct zynqmp_ipi_mbox *mbox;
> @@ -940,13 +940,12 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
>         pdata->num_mboxes = num_mboxes;
>
>         mbox = pdata->ipi_mboxes;
> -       for_each_available_child_of_node(np, nc) {
> +       for_each_available_child_of_node_scoped(np, nc) {
>                 mbox->pdata = pdata;
>                 mbox->setup_ipi_fn = ipi_fn;
>
>                 ret = zynqmp_ipi_mbox_probe(mbox, nc);
>                 if (ret) {
> -                       of_node_put(nc);
>                         dev_err(dev, "failed to probe subdev.\n");
>                         ret = -EINVAL;
>                         goto free_mbox_dev;
> --
> 2.51.0
>
Applied to mailbox/for-next.
Thanks.