linux-kernel - Re: [PATCH] mailbox: pcc: Remove spurious IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABb+yY1z36Tt+4EGzgcDp1GDZqVseNF7ZzLPGESrjPdbMdwksA@mail.gmail.com>
Date: Sun, 18 Jan 2026 14:55:28 -0600
From: Jassi Brar <jassisinghbrar@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Sudeep Holla <sudeep.holla@....com>, Aishwarya TCV <Aishwarya.TCV@....com>, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: pcc: Remove spurious IRQF_ONESHOT usage

On Fri, Jan 16, 2026 at 8:07 AM Mark Brown <broonie@...nel.org> wrote:
>
> The PCC code currently specifies IRQF_ONESHOT if the interrupt could
> potentially be shared but doesn't actually use request_threaded_irq() and
> the interrupt handler does not use IRQ_WAKE_THREAD so IRQF_ONESHOT is
> never relevant. Since commit aef30c8d569c ("genirq: Warn about using
> IRQF_ONESHOT without a threaded handler") specifying it has resulted in a
> WARN_ON(), fix this by removing IRQF_ONESHOT.
>
> Reported-by: Aishwarya TCV <Aishwarya.TCV@....com>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  drivers/mailbox/pcc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index ff292b9e0be9..060489e5ae6d 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -552,7 +552,7 @@ static int pcc_startup(struct mbox_chan *chan)
>
>         if (pchan->plat_irq > 0) {
>                 irqflags = pcc_chan_plat_irq_can_be_shared(pchan) ?
> -                                               IRQF_SHARED | IRQF_ONESHOT : 0;
> +                                               IRQF_SHARED : 0;
>                 rc = devm_request_irq(chan->mbox->dev, pchan->plat_irq, pcc_mbox_irq,
>                                       irqflags, MBOX_IRQ_NAME, chan);
>                 if (unlikely(rc)) {
>
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20260115-mailbox-pcc-non-threaded-irq-1ca29631e051
>
> Best regards,
> --
> Mark Brown <broonie@...nel.org>
>
Applied to mailbox/for-next.
Thanks.