linux-kernel - Re: Clarifying confusion of our variable placement rules caused by cleanup.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260118160704.4f7dda8c@robin>
Date: Sun, 18 Jan 2026 16:07:04 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: James Bottomley <James.Bottomley@...senPartnership.com>
Cc: Alexey Dobriyan <adobriyan@...il.com>, Andy Shevchenko
 <andriy.shevchenko@...el.com>, ksummit@...ts.linux.dev, Dan Williams
 <dan.j.williams@...el.com>, linux-kernel <linux-kernel@...r.kernel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: Clarifying confusion of our variable placement rules caused by
 cleanup.h

On Sun, 18 Jan 2026 14:17:30 -0500
James Bottomley <James.Bottomley@...senPartnership.com> wrote:

> How is any of this relevant to a style document?  You're quibbling over
> individual maintainer foibles which, while they may be deeply held to
> you (and obviously are relevant to contributors to your subsystems

Not just me, there are other maintainers that feel this way.

> because they need to know your foibles), can't be part of our universal
> advice because not all maintainers agree (not even on the direction of
> the Christmas Tree).

I don't believe the direction is controversial with variable
declarations. Maybe for header files, in which case, either is fine
with me.

Again, it's mostly due to aesthetics and it's more of a guideline than
a rule (for me). I do know of other maintainers where they are more
strict about it than I am.

-- Steve