linux-kernel - Re: [PATCH v5 08/14] ntfs: update attrib operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd8fDfrbtRODYcNPCtceqJt1EG0Vywdb=tYUtXhbh06_5Q@mail.gmail.com>
Date: Sun, 18 Jan 2026 14:00:24 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, tytso@....edu, 
	willy@...radead.org, jack@...e.cz, djwong@...nel.org, josef@...icpanda.com, 
	sandeen@...deen.net, rgoldwyn@...e.com, xiang@...nel.org, dsterba@...e.com, 
	pali@...nel.org, ebiggers@...nel.org, neil@...wn.name, amir73il@...il.com, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com, gunho.lee@....com, 
	Hyunchul Lee <hyc.lee@...il.com>
Subject: Re: [PATCH v5 08/14] ntfs: update attrib operations

On Fri, Jan 16, 2026 at 6:18 PM Christoph Hellwig <hch@....de> wrote:
>
> > +/* log base 2 of the number of entries in the hash table for match-finding.  */
> > +#define HASH_SHIFT           14
> > +
> > +/* Constant for the multiplicative hash function.  */
> > +#define HASH_MULTIPLIER              0x1E35A7BD
>
> The hashing here doesn't seem very efficient.  Is that part of
> the on-disk format in some way?  If so it would be great to
> document that.  If not it might be worth to look into better
> hashing helpers from the library functions in the kernel (not needed
> for inclusion, but probably worth it).
I will check it and add the comment if needed.
>
> > +struct COMPRESS_CONTEXT {
>
> Other parts of the code got rid of the Window-Style all upper
> case names, why add a new one here?
Ah, Okay, I will change it.
Thanks!
>