linux-kernel - Re: [PATCH 01/17] drm/amd/display: Return if DisplayID not found in parse_amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b535614d27e30831628b4a70b7ed825fd03791d4@intel.com>
Date: Mon, 19 Jan 2026 15:23:18 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Tomasz Pakuła <tomasz.pakula.oficjalny@...il.com>,
 alexander.deucher@....com, harry.wentland@....com, sunpeng.li@....com
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 siqueira@...lia.com, dri-devel@...ts.freedesktop.org,
 amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 tomasz.pakula.oficjalny@...il.com, bernhard.berger@...il.com
Subject: Re: [PATCH 01/17] drm/amd/display: Return if DisplayID not found in
 parse_amd_vsdb()

On Mon, 19 Jan 2026, Tomasz Pakuła <tomasz.pakula.oficjalny@...il.com> wrote:
> [Why]
> The function would continue to try to parse EDID even if DisplayID
> extension block wasn't found. Sometimes it got lucky and found AMD vsdb
> in CEA extension block which made debugging harder.
>
> [How]
> Add a return if DisplayID extension block wasn't found

Maybe don't use homegrown EDID parsing, but use drm_edid.c instead?

BR,
Jani.

>
> Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@...il.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 655c9fcb078a..a0d23853b8fc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -13113,6 +13113,9 @@ static int parse_amd_vsdb(struct amdgpu_dm_connector *aconnector,
>  			break;
>  	}
>  
> +	if (i == edid->extensions)
> +		return false;
> +
>  	while (j < EDID_LENGTH - sizeof(struct amd_vsdb_block)) {
>  		struct amd_vsdb_block *amd_vsdb = (struct amd_vsdb_block *)&edid_ext[j];
>  		unsigned int ieeeId = (amd_vsdb->ieee_id[2] << 16) | (amd_vsdb->ieee_id[1] << 8) | (amd_vsdb->ieee_id[0]);

-- 
Jani Nikula, Intel