linux-kernel - Re: [PATCH net] net: phy: intel-xway: fix OF node refcount leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aW467-D-2oBzFOY1@makrotopia.org>
Date: Mon, 19 Jan 2026 14:08:47 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: intel-xway: fix OF node refcount leakage

On Mon, Jan 19, 2026 at 03:05:54PM +0100, Andrew Lunn wrote:
> On Sun, Jan 18, 2026 at 03:57:04AM +0000, Daniel Golle wrote:
> > Automated review spotted an OF node reference count when checking if the
> > 'leds' child node exists. Call of_put_node() to maintain the refcount.
> > 
> > Link: https://netdev-ai.bots.linux.dev/ai-review.html?id=20f173ba-0c64-422b-a663-fea4b4ad01d0
> > Fixes: ("1758af47b98c1 net: phy: intel-xway: add support for PHY LEDs")
> > Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

I guess you meant to put your Reviewed-by: under v2 I've sent yesterday
because this initial submission has a fat-fingered Fixes:-tag...

See
https://patchwork.kernel.org/project/netdevbpf/patch/e3275e1c1cdca7e6426bb9c11f33bd84b8d900c8.1768783208.git.daniel@makrotopia.org/