linux-kernel - Re: [PATCH v2 02/10] gpu: nova-core: gsp: remove unnecessary Display impls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFSOHLZPC87U.3IIGQOCYH0E@garyguo.net>
Date: Mon, 19 Jan 2026 15:41:32 +0000
From: "Gary Guo" <gary@...yguo.net>
To: "Alexandre Courbot" <acourbot@...dia.com>, "Danilo Krummrich"
 <dakr@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>
Cc: "John Hubbard" <jhubbard@...dia.com>, "Alistair Popple"
 <apopple@...dia.com>, "Joel Fernandes" <joelagnelf@...dia.com>, "Timur
 Tabi" <ttabi@...dia.com>, "Edwin Peer" <epeer@...dia.com>, "Eliot Courtney"
 <ecourtney@...dia.com>, <nouveau@...ts.freedesktop.org>,
 <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, "Lyude Paul" <lyude@...hat.com>
Subject: Re: [PATCH v2 02/10] gpu: nova-core: gsp: remove unnecessary
 Display impls

On Tue Dec 16, 2025 at 4:27 AM GMT, Alexandre Courbot wrote:
> We only ever display these in debug context, for which the automatically
> derived `Debug` impls work just fine - so use them and remove these
> boilerplate-looking implementations.
> 
> Reviewed-by: Lyude Paul <lyude@...hat.com>
> Reviewed-by: Alistair Popple <apopple@...dia.com>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>

Reviewed-by: Gary Guo <gary@...yguo.net>

> ---
>  drivers/gpu/nova-core/gsp/cmdq.rs |  2 +-
>  drivers/gpu/nova-core/gsp/fw.rs   | 54 ---------------------------------------
>  2 files changed, 1 insertion(+), 55 deletions(-)