linux-kernel - Re: [PATCH v2] scsi: core: Don't free dev_name() and hold refcount for parent manually

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026011928-sliceable-shame-841d@gregkh>
Date: Mon, 19 Jan 2026 16:54:18 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Tzung-Bi Shih <tzungbi@...nel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: core: Don't free dev_name() and hold refcount
 for parent manually

On Mon, Jan 19, 2026 at 10:23:06PM +0800, Tzung-Bi Shih wrote:
>  static void scsi_host_cls_release(struct device *dev)
>  {
> -	put_device(&class_to_shost(dev)->shost_gendev);
> +	/*
> +	 * Keep an empty release() to prevent device_release() from emitting a
> +	 * warning.
> +	 */
>  }

Nope, sorry, something is VERY wrong if this is ever the case.  The
driver core is warning you for a very good reason, don't attempt to work
around that at all, the message was placed there to help you, not for
you to ignore.

thanks,

greg k-h