linux-kernel - Re: [PATCH v2 4/9] arm64: dts: imx8mm: add wakeup-source for usb phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aW5VzffP2UNAvy51@lizhi-Precision-Tower-5810>
Date: Mon, 19 Jan 2026 11:03:25 -0500
From: Frank Li <Frank.li@....com>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	devicetree@...r.kernel.org, Fabio Estevam <festevam@...il.com>,
	Sascha Hauer <s.hauer@...gutronix.de>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>,
	imx@...ts.linux.dev,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Nicolas Schier <nsc@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, Li Jun <jun.li@....com>
Subject: Re: [PATCH v2 4/9] arm64: dts: imx8mm: add wakeup-source for usb phy

On Sun, Jan 18, 2026 at 06:29:46PM +0100, Marco Felsch wrote:
> On 26-01-18, Marco Felsch wrote:
> > On 26-01-17, Frank Li wrote:
> > > From: Li Jun <jun.li@....com>
> > >
> > > USB phy can be wakeup source to support wakeup system from USB.
> >
> > Was USB wakeup tested? That beeing said, marking the device as
> > wakeup-src is fine.
> >
> > > Signed-off-by: Li Jun <jun.li@....com>
> > > Signed-off-by: Frank Li <Frank.Li@....com>
> >
> > Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>
>
> Just noticed that this targets the base soc.dtsi. IMHO this is board
> desicion to make and therefore belongs to the real board.dts(i) or dtso.
>
> Therefore please drop my r-b.

wakeup-source is captiblity of hardware. The user need use echo 1 > wakeup
to enable it. it is SOC's feature.

Frank

>
> Regards,
>   Marco
>
>
> --
> #gernperDu
> #CallMeByMyFirstName
>
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |