linux-kernel - Re: [PATCH] spi: rockchip: Use plain request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4406022b-11b5-4622-9662-5c3ba054e5ea@sirena.org.uk>
Date: Mon, 19 Jan 2026 16:25:12 +0000
From: Mark Brown <broonie@...nel.org>
To: Shawn Lin <shawn.lin@...k-chips.com>
Cc: Aishwarya TCV <Aishwarya.TCV@....com>, linux-spi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Heiko Stuebner <heiko@...ech.de>,
	"xuhui.lin@...k-chips.com" <xuhui.lin@...k-chips.com>
Subject: Re: [PATCH] spi: rockchip: Use plain request_irq()

On Sat, Jan 17, 2026 at 10:10:09AM +0800, Shawn Lin wrote:
> 在 2026/01/16 星期五 23:37, Mark Brown 写道:

> > TBH it looked to me more like there'd been some deferral of more complex
> > work at some point but that didn't make it into the final code.  In

> Ah, indeed，rockchip_spi_isr() directly performs R/W pio in hardirq
> context which doesn't seem advisable, so probably some better
> improvement is needed in the furture. Anyway, fix the warning right
> now as $subject patch looks sensible:

Generally the best pattern with this stuff is to do PIO in process
context - it looks like the driver already has a copybreak to use DMA
for larger transfers on systems that have DMA support so this should
only be happening for very short transfers in which case the context
thrashing from going to interrupt context is probably hurting
performance anyway.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)