linux-kernel - Re: [PATCH v3 3/3] spi: xilinx: use device property accessors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e559e33-4f2f-40d4-a15f-584548bd6057@sirena.org.uk>
Date: Mon, 19 Jan 2026 16:50:13 +0000
From: Mark Brown <broonie@...nel.org>
To: Abdurrahman Hussain <abdurrahman@...thop.ai>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Michal Simek <michal.simek@....com>, linux-spi@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] spi: xilinx: use device property accessors.

On Mon, Jan 19, 2026 at 08:47:17AM -0800, Abdurrahman Hussain wrote:
> > On Jan 19, 2026, at 8:32 AM, Mark Brown <broonie@...nel.org> wrote:
> > On Mon, Jan 19, 2026 at 07:06:24AM +0000, Abdurrahman Hussain via B4 Relay wrote:

> >> -		of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> >> -					  &num_cs);
> >> -		ret = of_property_read_u32(pdev->dev.of_node,
> >> -					   "xlnx,num-transfer-bits",
> >> -					   &bits_per_word);
> >> +		device_property_read_u32(&pdev->dev, "xlnx,num-ss-bits",
> >> +					 &num_cs);
> >> +		ret = device_property_read_u32(&pdev->dev,
> >> +					       "xlnx,num-transfer-bits",
> >> +					       &bits_per_word);

> > Are these bindings appropraite for ACPI systems?

> Yes, the Xilinx IP blocks are memory mapped and work exactly the same on ACPI as they do on DT.

That does not answer the question at all.  Is it appropriate to
configure an ACPI system in this way?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)