linux-kernel - Re: [PATCH net] idpf: Fix data race in idpf_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLuo+A3M0BSXKJwwsd4T+crXe8u0KiAns7=ks1TXnWaeQ@mail.gmail.com>
Date: Mon, 19 Jan 2026 18:59:45 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: David Yang <mmyangfl@...il.com>
Cc: netdev@...r.kernel.org, Tony Nguyen <anthony.l.nguyen@...el.com>, 
	Przemek Kitszel <przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Pavan Kumar Linga <pavan.kumar.linga@...el.com>, Phani Burra <phani.r.burra@...el.com>, 
	Willem de Bruijn <willemb@...gle.com>, Alan Brady <alan.brady@...el.com>, 
	Sridhar Samudrala <sridhar.samudrala@...el.com>, Joshua Hay <joshua.a.hay@...el.com>, 
	intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] idpf: Fix data race in idpf_net_dim

On Mon, Jan 19, 2026 at 5:28 PM David Yang <mmyangfl@...il.com> wrote:
>
> In idpf_net_dim(), some statistics protected by u64_stats_sync, are read
> and accumulated in ignorance of possible u64_stats_fetch_retry() events.
> The correct way to copy statistics is already illustrated by
> idpf_add_queue_stats(). Fix this by reading them into temporary variables
> first.
>
> Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support")
> Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support")
> Signed-off-by: David Yang <mmyangfl@...il.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

It seems ovs_vport_get_upcall_stats() has a similar bug, are you
interested to fix it as well ?

Thanks !