linux-kernel - Re: [PATCH 3/4] iio: proximity: vl53l0x-i2c: Fix reset sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aW52bwvXOrsSUMLX@smile.fi.intel.com>
Date: Mon, 19 Jan 2026 20:22:39 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: petr.hodina@...tonmail.com
Cc: Song Qiang <songqiang1304521@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, David Heidelberg <david@...t.cz>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] iio: proximity: vl53l0x-i2c: Fix reset sequence

On Mon, Jan 19, 2026 at 06:19:57PM +0100, Petr Hodina via B4 Relay wrote:

> Fix the reset GPIO handling and power-up timing to better match the
> VL53L0X reset requirements.

...

> -	usleep_range(3200, 5000);
> +	usleep_range(5000, 6000);

> +		usleep_range(5000, 6000);

> +		usleep_range(5000, 6000);

Can you switch to fsleep() while at it?

...

> -	data->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", GPIOD_OUT_HIGH);
> +	data->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", GPIOD_OUT_LOW);
>  	if (IS_ERR(data->reset_gpio))
>  		return dev_err_probe(&client->dev, PTR_ERR(data->reset_gpio),
>  				     "Cannot get reset GPIO\n");

Wondering if in a future change this can be converted to use reset-gpio driver
instead of poking GPIOs directly.

-- 
With Best Regards,
Andy Shevchenko