linux-kernel - [PATCH rdma-next] RDMA/core: release devices_rwsem when calling device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec221ec7-6abb-41b7-9237-8e799bbb5683@oracle.com>
Date: Mon, 19 Jan 2026 11:43:52 -0800
From: Sharath Srinivasan <sharath.srinivasan@...cle.com>
To: Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
        Parav Pandit <parav@...dia.com>
Cc: linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sharath Srinivasan <sharath.srinivasan@...cle.com>
Subject: [PATCH rdma-next] RDMA/core: release devices_rwsem when calling
 device_del

The sync strategy in remove_all_compat_devs() can improved
by adopting that of rdma_dev_exit_net() which releases devices_rwsem
before calling remove_one_compat_dev()/device_del().

Also fixes a comment typo in rdma_dev_exit_net().

Fixes: 2b34c5580226 ("RDMA/core: Add command to set ib_core device net namspace sharing mode")
Signed-off-by: Sharath Srinivasan <sharath.srinivasan@...cle.com>
---
 drivers/infiniband/core/device.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 1174ab7da629..81689924fab8 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -1078,6 +1078,13 @@ static void remove_all_compat_devs(void)
        xa_for_each (&devices, index, dev) {
                unsigned long c_index = 0;

+               get_device(&dev->dev);
+               /*
+                * Release the devices_rwsem so that potentially blocking
+                * device_del doesn't hold the devices_rwsem for too long.
+                */
+               up_read(&devices_rwsem);
+
                /* Hold nets_rwsem so that any other thread modifying this
                 * system param can sync with this thread.
                 */
@@ -1085,6 +1092,9 @@ static void remove_all_compat_devs(void)
                xa_for_each (&dev->compat_devs, c_index, cdev)
                        remove_one_compat_dev(dev, c_index);
                up_read(&rdma_nets_rwsem);
+
+               put_device(&dev->dev);
+               down_read(&devices_rwsem);
        }
        up_read(&devices_rwsem);
 }
@@ -1168,8 +1178,8 @@ static void rdma_dev_exit_net(struct net *net)
        xa_for_each (&devices, index, dev) {
                get_device(&dev->dev);
                /*
-                * Release the devices_rwsem so that pontentially blocking
-                * device_del, doesn't hold the devices_rwsem for too long.
+                * Release the devices_rwsem so that potentially blocking
+                * device_del doesn't hold the devices_rwsem for too long.
                 */
                up_read(&devices_rwsem);

--
2.39.5 (Apple Git-154)