[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb2d36a3-1c0d-40ab-aa44-e94089ca141a@arm.com>
Date: Mon, 19 Jan 2026 20:54:19 +0000
From: Ben Horgan <ben.horgan@....com>
To: Gavin Shan <gshan@...hat.com>
Cc: amitsinght@...vell.com, baisheng.gao@...soc.com,
baolin.wang@...ux.alibaba.com, carl@...amperecomputing.com,
dave.martin@....com, david@...nel.org, dfustini@...libre.com,
fenghuay@...dia.com, james.morse@....com, jonathan.cameron@...wei.com,
kobak@...dia.com, lcherian@...vell.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
peternewman@...gle.com, punit.agrawal@....qualcomm.com,
quic_jiles@...cinc.com, reinette.chatre@...el.com, rohit.mathew@....com,
scott@...amperecomputing.com, sdonthineni@...dia.com,
tan.shaopeng@...itsu.com, xhao@...ux.alibaba.com, catalin.marinas@....com,
will@...nel.org, corbet@....net, maz@...nel.org, oupton@...nel.org,
joey.gouly@....com, suzuki.poulose@....com, kvmarm@...ts.linux.dev
Subject: Re: [PATCH v3 44/47] arm_mpam: Add workaround for T241-MPAM-1
Hi Gavin,
On 1/19/26 12:16, Gavin Shan wrote:
> On 1/13/26 12:59 AM, Ben Horgan wrote:
>> +#define MPAM_IIDR_NVIDIA_T241
>> FIELD_PREP_CONST(MPAMF_IIDR_PRODUCTID, 0x241) | \
>> + FIELD_PREP_CONST(MPAMF_IIDR_VARIANT, 0) | \
>> + FIELD_PREP_CONST(MPAMF_IIDR_REVISION, 0) | \
>> + FIELD_PREP_CONST(MPAMF_IIDR_IMPLEMENTER, 0x36b)
>> +
>
> An error reported by checkpatch.pl as below.
>
> ERROR: Macros with complex values should be enclosed in parentheses
> #205: FILE: drivers/resctrl/mpam_internal.h:247:
> +#define MPAM_IIDR_NVIDIA_T241
> FIELD_PREP_CONST(MPAMF_IIDR_PRODUCTID, 0x241) | \
> + FIELD_PREP_CONST(MPAMF_IIDR_VARIANT, 0) | \
> + FIELD_PREP_CONST(MPAMF_IIDR_REVISION, 0) | \
> + FIELD_PREP_CONST(MPAMF_IIDR_IMPLEMENTER, 0x36b)
Fixed
>
>
>> /* The values for MSMON_CFG_MBWU_FLT.RWBW */
>> enum mon_filter_options {
>> COUNT_BOTH = 0,
>
> Thanks,
> Gavin
>
Thanks,
Ben
Powered by blists - more mailing lists