linux-kernel - Re: [PATCH net] be2net: fix data race in be_get_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c115ac23-9c22-49b9-81c4-c3f4ec987603@linux.dev>
Date: Mon, 19 Jan 2026 21:13:49 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: David Yang <mmyangfl@...il.com>, netdev@...r.kernel.org
Cc: Ajit Khaparde <ajit.khaparde@...adcom.com>,
 Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
 Somnath Kotur <somnath.kotur@...adcom.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Sathya Perla <sathya.perla@...gotech.com>,
 Padmanabh Ratnakar <padmanabh.ratnakar@...gotech.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] be2net: fix data race in be_get_new_eqd

On 19/01/2026 15:34, David Yang wrote:
> In be_get_new_eqd(), statistics of pkts, protected by u64_stats_sync, are
> read and accumulated in ignorance of possible u64_stats_fetch_retry()
> events. Before the commit in question, these statistics were retrieved
> one by one directly from queues. Fix this by reading them into temporary
> variables first.
> 
> Fixes: 209477704187 ("be2net: set interrupt moderation for Skyhawk-R using EQ-DB")
> Signed-off-by: David Yang <mmyangfl@...il.com>

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>