linux-kernel - Re: [PATCH] wifi: iwlwifi: ptp: Fix potential race condition in PTP removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a28ff161-b417-46c0-b56b-d4cb6e11dc48@linux.dev>
Date: Mon, 19 Jan 2026 21:32:58 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Junjie Cao <junjie.cao@...el.com>,
 Miri Korenblit <miriam.rachel.korenblit@...el.com>,
 Johannes Berg <johannes.berg@...el.com>, linux-wireless@...r.kernel.org,
 Richard Cochran <richardcochran@...il.com>
Cc: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Yedidya Benshimol <yedidya.ben.shimol@...el.com>,
 Avraham Stern <avraham.stern@...el.com>,
 Daniel Gabay <daniel.gabay@...el.com>,
 Krishnanand Prabhu <krishnanand.prabhu@...el.com>,
 Luca Coelho <luciano.coelho@...el.com>,
 Gregory Greenman <gregory.greenman@...el.com>, stable@...r.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: ptp: Fix potential race condition in PTP
 removal

On 15/01/2026 16:15, Junjie Cao wrote:
> iwl_mvm_ptp_remove() and iwl_mld_ptp_remove() call
> cancel_delayed_work_sync() only after ptp_clock_unregister() and after
> partially clearing ptp_data state.
> 
> This creates a race where the delayed work (iwl_mvm_ptp_work /
> iwl_mld_ptp_work) can run while teardown is in progress and observe a
> partially modified PTP state. In addition, the work may re-arm itself,
> extending the teardown window and risking execution after driver
> resources have been released.
> 
> Move cancel_delayed_work_sync() before ptp_clock_unregister() to ensure
> the delayed work is fully stopped before any PTP cleanup begins. This
> follows the standard pattern used by other Intel PTP drivers such as
> e1000e, igb, ixgbe, and ice.
> 
> Fixes: d1e879ec600f ("wifi: iwlwifi: add iwlmld sub-driver")
> Fixes: 1595ecce1cf3 ("wifi: iwlwifi: mvm: add support for PTP HW clock (PHC)")
> Cc: stable@...r.kernel.org
> Signed-off-by: Junjie Cao <junjie.cao@...el.com>

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>