Message-ID: <aW3GWZl8AmzsTEu0@zatzit>
Date: Mon, 19 Jan 2026 16:51:21 +1100
From: David Gibson <david@...son.dropbear.id.au>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Ayush Singh <ayush@...gleboard.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	devicetree-compiler@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree-spec@...r.kernel.org,
	Hui Pu <hui.pu@...ealthcare.com>,
	Ian Ray <ian.ray@...ealthcare.com>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [RFC PATCH 19/77] dtc: Introduce export symbols

On Fri, Jan 16, 2026 at 05:27:35PM +0100, Herve Codina wrote:
> Hi David,
> 
> On Thu, 15 Jan 2026 16:52:26 +1100
> David Gibson <david@...son.dropbear.id.au> wrote:
> 
> > On Mon, Jan 12, 2026 at 03:19:09PM +0100, Herve Codina wrote:
> > > Export symbols allow to define a list of symbols exported at a given
> > > node level. Those exported symbols can be used by an addon when the
> > > addon is applied on the node exporting the symbols.  
> > 
> > This seems to imply an addon always applies at a single node location.
> > I'm not sure that's a good design choice, since I don't see how it
> > covers the case of something that connects to several connectors.
> 
> Apply the addon on a node that knows about those connectors.

That seems limiting to me, because it requires the base tree to know
about all possible connector combinations, which I'm not sure is
feasible.  If I understood Geert(?)'s case properly, there are use
cases where a board might have, say, six "type foo" connectors, and an
addon board could connect to any two of those.  Of a board might have
3 "type foo" and 3 "type bar" connectors and an addon board needs to
connect to (any) of each.  It seems much more natural to me that at
attach time you say
	"addon foo 0 => board foo 1, addon foo 1 => board foo 5"
or	"addon foo 0 => board foo 2, addon bar 0 => board bar 1"

Rather than the board itself having to anticipate all combinations.

> > > In order to perform
> > > its symbol resolution. Any unresolved phandle value will be resolved
> > > using those exported symbols.
> > > 
> > > The feature is similar to __symbols__ involved with overlay but while
> > > all symbols are visible with __symbols__, only specific symbols
> > > (exported symbols) are visible with export symbols.  
> > 
> > This paragraph doesn't make sense to me.  What's a "symbol" if it's
> > not something in __symbols__ or export symbols?
> 
> An imported symbols ?
> 
> /import/ foo "blabla";
> 
> from the addon point of view where this /import/ is present, 'foo' is a
> symbol.

I guess, but existing plugin stuff doesn't really have imported
symbols, so the example doesn't really illuminate the difference from
the status quo.

> > > Also an exported symbol has a specific name and this name has to
> > > used for symbol resolution. Having this specific name allows to:
> > > 
> > >   - Have several nodes providing the same exported symbols
> > >     name but each of them pointing to different nodes.  
> > 
> > That's not a property of having a specific name, that's a property of
> > being local to a node.
> 
> Yes, exactly. I will reword.
> 
> Best regards,
> Hervé
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists