linux-kernel - Re: [PATCH v7 2/3] sched/fair: Remove task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <846a25a5-60d4-4d6c-8d06-cd7b96fce8df@amd.com>
Date: Mon, 19 Jan 2026 12:13:13 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: Zecheng Li <zli94@...u.edu>, Ingo Molnar <mingo@...hat.com>, "Peter
 Zijlstra" <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>,
	"Vincent Guittot" <vincent.guittot@...aro.org>
CC: Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt
	<rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel Gorman
	<mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>, Rik van Riel
	<riel@...riel.com>, Chris Mason <clm@...com>, Madadi Vineeth Reddy
	<vineethr@...ux.ibm.com>, Xu Liu <xliuprof@...gle.com>, Blake Jones
	<blakejones@...gle.com>, Josh Don <joshdon@...gle.com>, Nilay Vaish
	<nilayvaish@...gle.com>, <linux-kernel@...r.kernel.org>, Zecheng Li
	<zecheng@...gle.com>
Subject: Re: [PATCH v7 2/3] sched/fair: Remove task_group->se pointer array

Hello Zecheng,

On 1/18/2026 9:04 AM, Zecheng Li wrote:
> @@ -2201,6 +2200,26 @@ struct cfs_tg_state {
>  	struct sched_entity	se;
>  	struct sched_statistics	stats;
>  } __no_randomize_layout;
> +
> +static inline struct sched_entity *tg_se(struct task_group *tg, int cpu)
> +{
> +	if (is_root_task_group(tg))
> +		return NULL;
> +
> +	struct cfs_tg_state *state =

nit. Can you move the declaration of "struct cfs_tg_state *state" to the
top of the function. Same for cfs_rq_se().

> +		container_of(tg->cfs_rq[cpu], struct cfs_tg_state, cfs_rq);
> +	return &state->se;
> +}
> +
> +static inline struct sched_entity *cfs_rq_se(struct cfs_rq *cfs_rq)
> +{
> +	if (is_root_task_group(cfs_rq->tg))
> +		return NULL;
> +
> +	struct cfs_tg_state *state =
> +		container_of(cfs_rq, struct cfs_tg_state, cfs_rq);
> +	return &state->se;
> +}
>  #endif

-- 
Thanks and Regards,
Prateek