[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aW2HCTuwNEQkG8UC@lsvm11u0000554.swis.ap-northeast-2.aws.nxp.com>
Date: Mon, 19 Jan 2026 10:21:13 +0900
From: Yanan Yang <yanan.yang@....com>
To: Daniel Baluta <daniel.baluta@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, qijian.guo@....com,
justin.jiang@....com, Lei Xu <lei.xu@....com>,
Xiaofeng Wei <xiaofeng.wei@....com>
Subject: Re: [PATCH v3 2/2] arm64: dts: freescale: add NXP FRDM-IMX91S board
support
On Fri, Jan 16, 2026 at 11:33:59AM +0200, Daniel Baluta wrote:
> On Fri, Jan 16, 2026 at 5:45 AM Yanan Yang <yanan.yang@....com> wrote:
> >
> > Add DeviceTree support for the NXP FRDM-IMX91S development board based
> > on the i.MX91 SoC. FRDM-IMX91S is a cost-optimized variant of FRDM-IMX91
> > and differs in memory, storage, Ethernet, and PMIC configuration:
> >
> > - 512MB LPDDR4 (FRDM-IMX91 uses 1GB)
> > - 256MB FlexSPI-NAND (FRDM-IMX91 uses 8GB eMMC)
> > - Single GbE port (FRDM-IMX91 has dual GbE)
> > - PMIC PF9453 (FRDM-IMX91 uses PCA9451A)
> >
>
> <snip>
>
>
> > + sound-mqs {
> > + compatible = "fsl,imx6sx-sdb-mqs", "fsl,imx-audio-mqs";
>
> There is little sense to have compatible = ""fsl,imx6sx-sdb-mqs". Just
> use
>
> compatible = "fsl,imx-audio-mqs";
>
> Move model property after compatible as per already existing code practice.
I will fix it in v4. Thanks
Powered by blists - more mailing lists