Message-ID: <aW3cdlSjcXqcV1VO@infradead.org>
Date: Sun, 18 Jan 2026 23:25:42 -0800
From: Christoph Hellwig <hch@...radead.org>
To: NeilBrown <neil@...wn.name>
Cc: Christoph Hellwig <hch@...radead.org>, Jeff Layton <jlayton@...nel.org>,
	Amir Goldstein <amir73il@...il.com>,
	Christian Brauner <brauner@...nel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Chuck Lever <chuck.lever@...cle.com>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
	Hugh Dickins <hughd@...gle.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Theodore Ts'o <tytso@....edu>,
	Andreas Dilger <adilger.kernel@...ger.ca>, Jan Kara <jack@...e.com>,
	Gao Xiang <xiang@...nel.org>, Chao Yu <chao@...nel.org>,
	Yue Hu <zbestahu@...il.com>, Jeffle Xu <jefflexu@...ux.alibaba.com>,
	Sandeep Dhavale <dhavale@...gle.com>,
	Hongbo Li <lihongbo22@...wei.com>,
	Chunhai Guo <guochunhai@...o.com>, Carlos Maiolino <cem@...nel.org>,
	Ilya Dryomov <idryomov@...il.com>,
	Alex Markuze <amarkuze@...hat.com>,
	Viacheslav Dubeyko <slava@...eyko.com>, Chris Mason <clm@...com>,
	David Sterba <dsterba@...e.com>,
	Luis de Bethencourt <luisbg@...nel.org>,
	Salah Triki <salah.triki@...il.com>,
	Phillip Lougher <phillip@...ashfs.org.uk>,
	Steve French <sfrench@...ba.org>,
	Paulo Alcantara <pc@...guebit.org>,
	Ronnie Sahlberg <ronniesahlberg@...il.com>,
	Shyam Prasad N <sprasad@...rosoft.com>,
	Bharath SM <bharathsm@...rosoft.com>,
	Miklos Szeredi <miklos@...redi.hu>,
	Mike Marshall <hubcap@...ibond.com>,
	Martin Brandenburg <martin@...ibond.com>,
	Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>,
	Joseph Qi <joseph.qi@...ux.alibaba.com>,
	Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
	Ryusuke Konishi <konishi.ryusuke@...il.com>,
	Trond Myklebust <trondmy@...nel.org>,
	Anna Schumaker <anna@...nel.org>, Dave Kleikamp <shaggy@...nel.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Richard Weinberger <richard@....at>, Jan Kara <jack@...e.cz>,
	Andreas Gruenbacher <agruenba@...hat.com>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Jaegeuk Kim <jaegeuk@...nel.org>, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org, linux-ext4@...r.kernel.org,
	linux-erofs@...ts.ozlabs.org, linux-xfs@...r.kernel.org,
	ceph-devel@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-cifs@...r.kernel.org, linux-unionfs@...r.kernel.org,
	devel@...ts.orangefs.org, ocfs2-devel@...ts.linux.dev,
	ntfs3@...ts.linux.dev, linux-nilfs@...r.kernel.org,
	jfs-discussion@...ts.sourceforge.net, linux-mtd@...ts.infradead.org,
	gfs2@...ts.linux.dev, linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH 00/29] fs: require filesystems to explicitly opt-in to
 nfsd export support

On Mon, Jan 19, 2026 at 06:22:42PM +1100, NeilBrown wrote:
> We are calling it for it's only use.  If there was ever another use, we
> could change the name if that made sense.  It is not a public name, it
> is easy to change.

No, it is not the only use.  This flag needs to be propagate to
userspace through statx or the file attrs.  As I said before there
is plenty of code in userspace that does rely on the traditional
file handle semantics.

> > Remember nfs also support volatile file handles, and other applications
> > might rely on this (I know of quite a few user space applications that
> > do, but they are kinda hardwired to xfs anyway).
> 
> The NFS protocol supports volatile file handles.  knfsd does not.
> So maybe
>   EXPORT_OP_NOT_NFSD_COMPATIBLE
> might be better.  or EXPORT_OP_NOT_LINUX_NFSD_COMPATIBLE.
> (I prefer opt-out rather than opt-in because nfsd export was the
> original purpose of export_operations, but it isn't something
> I would fight for)

Again, stop trying to name things of the initial user.  Flag needs to
describe smenatics, not users.

Powered by blists - more mailing lists