linux-kernel - Re: [PATCH 0/9] gpib: Unify *allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aW3enNsGsE_hKtKR@stanley.mountain>
Date: Mon, 19 Jan 2026 10:34:52 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>
Cc: Dave Penkler <dpenkler@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michael Rubin <matchstick@...erthere.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/9] gpib: Unify *allocate_private

On Tue, Jan 13, 2026 at 07:08:37PM +0000, Dominik Karol Piątkowski wrote:
> Recently, gpib driver got out of staging area. There is still a bit of work that
> can be done to improve it.
> 
> Return values for *allocate_private functions as well as calling code in
> gpib driver are all over the place. Unify them by returning -errno if
> something fails, zero otherwise. Use the returned value as early return
> value in case of error.
> 
> Untouched gpib files already use the proposed convention.
> 
> Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>

I don't see the point of the allocate_private() functions.  Why not
just open code it?

regards,
dan carpenter