linux-kernel - Re: [PATCH v10 2/3] clk: canaan: Add clock driver for Canaan K230

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aW3o8xVziqb9iRBN@duge-virtual-machine>
Date: Mon, 19 Jan 2026 16:18:59 +0800
From: Jiayu Du <jiayu.riscv@...c.iscas.ac.cn>
To: Xukai Wang <kingxukai@...omail.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Conor Dooley <conor@...nel.org>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
	Samuel Holland <samuel.holland@...ive.com>,
	Troy Mitchell <TroyMitchell988@...il.com>
Subject: Re: [PATCH v10 2/3] clk: canaan: Add clock driver for Canaan K230

> +
> +K230_CLK_GATE_FORMAT(hs_hclk_src_gate,
> +		     K230_HS_HCLK_SRC_GATE,
> +		     0x18, 0, 0, 0,
> +		     &hs_hclk_high_src_rate.clk.hw);

Here, you replaced hs_hclk_high_gate(in v9) with hs_hclk_high_src_rate,
but after my board test, I find that when hs_hclk_high_gate is turned
off, the mmc/sd and other high-speed subsystems can not work. So maybe
you should not change the hs_hclk_high_gate to hs_hclk_high_src_rate.

When I used clk_ignore_unused, I saw the log as follows, while the enable
and prepare count of hs_hclk_high_gate is zero. Here is the log:
       pll0_div4                     5  5  0  400000000   0   0     50000      Y  deviceless   no_connection_id
          hs_hclk_high_src_rate      1  1  0  400000000   0   0     50000      Y     deviceless   no_connection_id
             hs_hclk_high_gate       0  0  0  400000000   0   0     50000      Y        deviceless   no_connection_id
             hs_hclk_src_gate        1  1  0  400000000   0   0     50000      Y        deviceless   no_connection_id
                hs_hclk_src_rate     4  4  0  200000000   0   0     50000      Y           deviceless   no_connection_id
                   hs_sd0_ahb_gate   1  1  0  200000000   0   0     50000      Y              91580000.mmc   ahb
                                                                                            deviceless   no_connection_id
                   hs_sd1_ahb_gate   1  1  0  200000000   0   0     50000      Y              91581000.mmc   ahb
                                                                                            deviceless   no_connection_id
                   hs_ssi1_ahb_gate  0  0  0  200000000   0   0     50000      Y              deviceless   no_connection_id
                   hs_ssi2_ahb_gate  0  0  0  200000000   0   0     50000      Y              deviceless   no_connection_id
                   hs_usb0_ahb_gate  1  1  0  200000000   0   0     50000      Y              91500000.usb   otg
                                                                                            deviceless   no_connection_id
                   hs_usb1_ahb_gate  1  1  0  200000000   0   0     50000      Y              91540000.usb   otg

Regards,
Jiayu Du
> +
> +K230_CLK_RATE_FORMAT(hs_hclk_src_rate,
> +		     K230_HS_HCLK_SRC_RATE,