linux-kernel - [PATCH 1/5] of: Add of_property_read_[u32,s32]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260119-add_dt_default-v1-1-db4787ea7a9e@nxp.com>
Date: Mon, 19 Jan 2026 10:02:54 +0800
From: "Peng Fan (OSS)" <peng.fan@....nxp.com>
To: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...nel.org>, 
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
 Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Peng Fan <peng.fan@....com>
Subject: [PATCH 1/5] of: Add of_property_read_[u32,s32]_default

From: Peng Fan <peng.fan@....com>

Introduce new helper functions of_property_read_u32_default() and
of_property_read_s32_default() to simplify reading optional device tree
properties with a default value.

A very common pattern in drivers is to provide a default value and let
of_property_read_*() override it when the property is present, e.g.:

    Y = Y_DEFAULT;
    of_property_read_u32(np, "prop", &Y);

or equivalently, checking the return value explicitly:

    ret = of_property_read_u32(np, "prop", &val);
    if (ret)
        Y = Y_DEFAULT;
    else
        Y = val;

Both forms express the same intent: the property is optional and a
well-defined default should be used if it cannot be read.

With the new helper, this can be expressed more directly as:

    Y = of_property_read_u32_default(np, "prop", Y_DEFAULT);

The helpers intentionally ignore the error code and return either the
parsed value or the supplied default. They are meant for optional
properties only. Callers that need to handle or propagate errors should
continue using of_property_read_*() directly.

Signed-off-by: Peng Fan <peng.fan@....com>
---
 include/linux/of.h | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index 9bbdcf25a2b448ba4ec5ddee8b35a105ca4aab8b..ef9f63755b20722969b682eae98a0dbd8cb21d58 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -1450,6 +1450,25 @@ static inline int of_property_read_u32(const struct device_node *np,
 	return of_property_read_u32_array(np, propname, out_value, 1);
 }
 
+
+/**
+ * of_property_read_u32_default() - Read a u32 DT property or return a default.
+ * @np:		device node
+ * @propname:	property name
+ * @def:	default value to return if the property cannot be read
+ *
+ * Return: The property value on success, or @def if the property is missing
+ *         or invalid. This helper intentionally ignores the error code; it
+ *         is intended for optional properties with a sensible default.
+ */
+static inline u32 of_property_read_u32_default(const struct device_node *np,
+					       const char *propname,
+					       u32 def)
+{
+	of_property_read_u32(np, propname, &def);
+	return def;
+}
+
 static inline int of_property_read_s32(const struct device_node *np,
 				       const char *propname,
 				       s32 *out_value)
@@ -1457,6 +1476,25 @@ static inline int of_property_read_s32(const struct device_node *np,
 	return of_property_read_u32(np, propname, (u32*) out_value);
 }
 
+
+/**
+ * of_property_read_s32_default() - Read an s32 DT property or return a default.
+ * @np:		device node
+ * @propname:	property name
+ * @def:	default value to return if the property cannot be read
+ *
+ * Return: The property value on success, or @def if the property is missing
+ *	   or invalid. This helper intentionally ignores the error code; it
+ *	   is intended for optional properties with a sensible default.
+ */
+static inline s32 of_property_read_s32_default(const struct device_node *np,
+					       const char *propname,
+					       s32 def)
+{
+	of_property_read_s32(np, propname, &def);
+	return def;
+}
+
 #define of_for_each_phandle(it, err, np, ln, cn, cc)			\
 	for (of_phandle_iterator_init((it), (np), (ln), (cn), (cc)),	\
 	     err = of_phandle_iterator_next(it);			\

-- 
2.37.1