linux-kernel - [PATCH 4/5] regulator: max77620: Use of_property_read_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260119-add_dt_default-v1-4-db4787ea7a9e@nxp.com>
Date: Mon, 19 Jan 2026 10:02:57 +0800
From: "Peng Fan (OSS)" <peng.fan@....nxp.com>
To: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...nel.org>, 
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
 Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Peng Fan <peng.fan@....com>
Subject: [PATCH 4/5] regulator: max77620: Use
 of_property_read_u32_default() for DT parsing

From: Peng Fan <peng.fan@....com>

Switch max77620_of_parse_cb() to of_property_read_u32_default() to simplify
device tree property parsing and remove duplicated error handling.

Properties that previously defaulted to -1 now explicitly use -1U,
preserving the original semantics.

No functional changes.

Signed-off-by: Peng Fan <peng.fan@....com>
---
 drivers/regulator/max77620-regulator.c | 40 ++++++++++++++--------------------
 1 file changed, 16 insertions(+), 24 deletions(-)

diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c
index 7bc87d8e9f686651067b443c06d0791557e1d1e6..6ba3c2a995198234c0aef5dfe445ef291e8be2dd 100644
--- a/drivers/regulator/max77620-regulator.c
+++ b/drivers/regulator/max77620-regulator.c
@@ -605,38 +605,30 @@ static int max77620_of_parse_cb(struct device_node *np,
 {
 	struct max77620_regulator *pmic = config->driver_data;
 	struct max77620_regulator_pdata *rpdata = &pmic->reg_pdata[desc->id];
-	u32 pval;
-	int ret;
 
-	ret = of_property_read_u32(np, "maxim,active-fps-source", &pval);
-	rpdata->active_fps_src = (!ret) ? pval : MAX77620_FPS_SRC_DEF;
+	rpdata->active_fps_src =
+		of_property_read_u32_default(np, "maxim,active-fps-source", MAX77620_FPS_SRC_DEF);
 
-	ret = of_property_read_u32(np, "maxim,active-fps-power-up-slot", &pval);
-	rpdata->active_fps_pu_slot = (!ret) ? pval : -1;
+	rpdata->active_fps_pu_slot =
+		of_property_read_u32_default(np, "maxim,active-fps-power-up-slot", -1U);
 
-	ret = of_property_read_u32(
-			np, "maxim,active-fps-power-down-slot", &pval);
-	rpdata->active_fps_pd_slot = (!ret) ? pval : -1;
+	rpdata->active_fps_pd_slot =
+		of_property_read_u32_default(np, "maxim,active-fps-power-down-slot", -1U);
 
-	ret = of_property_read_u32(np, "maxim,suspend-fps-source", &pval);
-	rpdata->suspend_fps_src = (!ret) ? pval : -1;
+	rpdata->suspend_fps_src =
+		of_property_read_u32_default(np, "maxim,suspend-fps-source", -1U);
 
-	ret = of_property_read_u32(
-			np, "maxim,suspend-fps-power-up-slot", &pval);
-	rpdata->suspend_fps_pu_slot = (!ret) ? pval : -1;
+	rpdata->suspend_fps_pu_slot =
+		of_property_read_u32_default(np, "maxim,suspend-fps-power-up-slot", -1U);
 
-	ret = of_property_read_u32(
-			np, "maxim,suspend-fps-power-down-slot", &pval);
-	rpdata->suspend_fps_pd_slot = (!ret) ? pval : -1;
+	rpdata->suspend_fps_pd_slot =
+		of_property_read_u32_default(np, "maxim,suspend-fps-power-down-slot", -1U);
 
-	ret = of_property_read_u32(np, "maxim,power-ok-control", &pval);
-	if (!ret)
-		rpdata->power_ok = pval;
-	else
-		rpdata->power_ok = -1;
+	rpdata->power_ok =
+		of_property_read_u32_default(np, "maxim,power-ok-control", -1U);
 
-	ret = of_property_read_u32(np, "maxim,ramp-rate-setting", &pval);
-	rpdata->ramp_rate_setting = (!ret) ? pval : 0;
+	rpdata->ramp_rate_setting =
+		of_property_read_u32_default(np, "maxim,ramp-rate-setting", 0);
 
 	return max77620_init_pmic(pmic, desc->id);
 }

-- 
2.37.1