linux-kernel - Re: [PATCH v2 19/21] x86/virt/tdx: Establish contexts for the new TDX Module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aW3wIRuLFSkGU+KI@intel.com>
Date: Mon, 19 Jan 2026 16:49:37 +0800
From: Chao Gao <chao.gao@...el.com>
To: Binbin Wu <binbin.wu@...ux.intel.com>
CC: <linux-coco@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
	<x86@...nel.org>, <reinette.chatre@...el.com>, <ira.weiny@...el.com>,
	<kai.huang@...el.com>, <dan.j.williams@...el.com>,
	<yilun.xu@...ux.intel.com>, <sagis@...gle.com>, <vannapurve@...gle.com>,
	<paulmck@...nel.org>, <nik.borisov@...e.com>, Farrah Chen
	<farrah.chen@...el.com>, "Kirill A. Shutemov" <kas@...nel.org>, Dave Hansen
	<dave.hansen@...ux.intel.com>, Thomas Gleixner <tglx@...utronix.de>, "Ingo
 Molnar" <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin"
	<hpa@...or.com>
Subject: Re: [PATCH v2 19/21] x86/virt/tdx: Establish contexts for the new
 TDX Module

>> +int tdx_module_run_update(void)
>> +{
>> +	struct tdx_module_args args = {};
>> +	int ret;> +
>> +	ret = seamcall(TDH_SYS_UPDATE, &args);
>
>Since it's a seamcall error, shouldn't it be u64?

Good catch. I will use seamcall_prerr(), which returns an int.

>
>> +	if (ret) {
>> +		tdx_module_status = TDX_MODULE_ERROR;
>> +		pr_info("module update failed: %d\n", ret);
>
>pr_info -> pr_err?

Yes.