linux-kernel - Re: [PATCH v3 9/9] crypto: atmel: Use dmaengine_prep_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc019bd8-34d3-420e-8519-09700437fb01@microchip.com>
Date: Mon, 19 Jan 2026 10:26:39 +0100
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Frank Li <Frank.Li@....com>, Vinod Koul <vkoul@...nel.org>, Manivannan
 Sadhasivam <mani@...nel.org>, Krzysztof Wilczyński
	<kwilczynski@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>, Bjorn
 Helgaas <bhelgaas@...gle.com>, Christoph Hellwig <hch@....de>, Sagi Grimberg
	<sagi@...mberg.me>, Chaitanya Kulkarni <kch@...dia.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea
	<claudiu.beznea@...on.dev>, Koichiro Den <den@...inux.co.jp>, Niklas Cassel
	<cassel@...nel.org>
CC: <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-pci@...r.kernel.org>, <linux-nvme@...ts.infradead.org>,
	<mhi@...ts.linux.dev>, <linux-arm-msm@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<imx@...ts.linux.dev>
Subject: Re: [PATCH v3 9/9] crypto: atmel: Use dmaengine_prep_config_single()
 API

On 05/01/2026 at 23:46, Frank Li wrote:
> Using new API dmaengine_prep_config_single() to simple code.
> 
> No functional change.
> 
> Tested-by: Niklas Cassel <cassel@...nel.org>
> Signed-off-by: Frank Li <Frank.Li@....com>

Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks, best regards,
   Nicolas

> ---
>   drivers/crypto/atmel-aes.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
> index 3a2684208dda9ee45d71b4bc2958be293a4fb6fe..e300672ffd7185b0f5bf356c2376681537047def 100644
> --- a/drivers/crypto/atmel-aes.c
> +++ b/drivers/crypto/atmel-aes.c
> @@ -795,7 +795,6 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd,
>          struct dma_slave_config config;
>          dma_async_tx_callback callback;
>          struct atmel_aes_dma *dma;
> -       int err;
> 
>          memset(&config, 0, sizeof(config));
>          config.src_addr_width = addr_width;
> @@ -820,12 +819,9 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd,
>                  return -EINVAL;
>          }
> 
> -       err = dmaengine_slave_config(dma->chan, &config);
> -       if (err)
> -               return err;
> -
> -       desc = dmaengine_prep_slave_sg(dma->chan, dma->sg, dma->sg_len, dir,
> -                                      DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
> +       desc = dmaengine_prep_config_sg(dma->chan, dma->sg, dma->sg_len, dir,
> +                                       DMA_PREP_INTERRUPT | DMA_CTRL_ACK,
> +                                       &config);
>          if (!desc)
>                  return -ENOMEM;
> 
> 
> --
> 2.34.1
>