linux-kernel - Re: [PATCH v15 2/9] erofs: decouple `struct erofs_anon_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ad34c0b-c880-48d5-a24e-8f2626e5f21d@huawei.com>
Date: Mon, 19 Jan 2026 10:23:19 +0800
From: Hongbo Li <lihongbo22@...wei.com>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>, Christoph Hellwig <hch@....de>
CC: <chao@...nel.org>, <brauner@...nel.org>, <djwong@...nel.org>,
	<amir73il@...il.com>, <linux-fsdevel@...r.kernel.org>,
	<linux-erofs@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v15 2/9] erofs: decouple `struct erofs_anon_fs_type`

Hi,

On 2026/1/19 9:44, Gao Xiang wrote:
> 
> 
> On 2026/1/19 09:34, Hongbo Li wrote:
>> Hi, Xiang
>>
>> On 2026/1/16 23:38, Christoph Hellwig wrote:
>>>> +#if defined(CONFIG_EROFS_FS_ONDEMAND)
>>>
>>> Normally this would just use #ifdef.
>>>
>> How about using #ifdef for all of them? I checked and there are only 
>> three places in total, and all of them are related to 
>> FS_PAGE_CACHE_SHARE or FS_ONDEMAND config macro.
> 
> I'm fine with most cases (including here).
> 
> But I'm not sure if there is a case as `#if defined() || defined()`,
> it seems it cannot be simply replaced with `#ifdef`.
> 
Yeah, we cannot replace it in this case. So I will keep it here because 
it will be changed into `#if defined() || defined()` in following steps. 
Instead, I will use this way in other place, such as:

```
#if defined(CONFIG_EROFS_FS_PAGE_CACHE_SHARE)
                 set_opt(&sbi->opt, INODE_SHARE);
#else
...
```

Thanks,
Hongbo


> Thanks,
> Gao Xiang
> 
>>
>> Thanks,
>> Hongbo
>