linux-kernel - Re: [PATCH] powerpc/52xx/mpc52xx_gpt: consolidate chained IRQ handler install/remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdcbihCL8MLoh4-WQuQ5L+BEOkurFmgsEB3FszyHYZdyg@mail.gmail.com>
Date: Mon, 19 Jan 2026 09:41:46 +0000
From: Bartosz Golaszewski <brgl@...nel.org>
To: Chen Ni <nichen@...as.ac.cn>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, agust@...x.de, 
	maddy@...ux.ibm.com, mpe@...erman.id.au, npiggin@...il.com, 
	chleroy@...nel.org, tglx@...nel.org, brgl@...nel.org, jirislaby@...nel.org
Subject: Re: [PATCH] powerpc/52xx/mpc52xx_gpt: consolidate chained IRQ handler install/remove

On Mon, 19 Jan 2026 07:12:32 +0100, Chen Ni <nichen@...as.ac.cn> said:
> The driver currently sets the handler data and the chained handler in
> two separate steps. This creates a theoretical race window where an
> interrupt could fire after the handler is set but before the data is
> assigned, leading to a NULL pointer dereference.
>
> Replace the two calls with irq_set_chained_handler_and_data() to set
> both the handler and its data atomically under the irq_desc->lock.
>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
> index 7748b6641a3c..e8163fdee69a 100644
> --- a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
> +++ b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
> @@ -253,8 +253,7 @@ mpc52xx_gpt_irq_setup(struct mpc52xx_gpt_priv *gpt, struct device_node *node)
>  		return;
>  	}
>
> -	irq_set_handler_data(cascade_virq, gpt);
> -	irq_set_chained_handler(cascade_virq, mpc52xx_gpt_irq_cascade);
> +	irq_set_chained_handler_and_data(cascade_virq, mpc52xx_gpt_irq_cascade, gpt);
>
>  	/* If the GPT is currently disabled, then change it to be in Input
>  	 * Capture mode.  If the mode is non-zero, then the pin could be
> --
> 2.25.1
>
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>