linux-kernel - Re: [PATCH 1/8] of: provide of_machine_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFSJ2AD562CP.1ZX1JO1F0Y1UU@kernel.org>
Date: Mon, 19 Jan 2026 12:26:25 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Bartosz Golaszewski" <bartosz.golaszewski@....qualcomm.com>
Cc: "Rob Herring" <robh@...nel.org>, "Saravana Kannan"
 <saravanak@...nel.org>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, "Christophe Leroy (CS GROUP)"
 <chleroy@...nel.org>, "Shawn Guo" <shawnguo@...nel.org>, "Sascha Hauer"
 <s.hauer@...gutronix.de>, "Pengutronix Kernel Team"
 <kernel@...gutronix.de>, "Fabio Estevam" <festevam@...il.com>, "Geert
 Uytterhoeven" <geert+renesas@...der.be>, "Magnus Damm"
 <magnus.damm@...il.com>, "Chen-Yu Tsai" <wens@...nel.org>, "Jernej Skrabec"
 <jernej.skrabec@...il.com>, "Samuel Holland" <samuel@...lland.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linuxppc-dev@...ts.ozlabs.org>, <linux-arm-kernel@...ts.infradead.org>,
 <imx@...ts.linux.dev>, <linux-renesas-soc@...r.kernel.org>,
 <linux-sunxi@...ts.linux.dev>
Subject: Re: [PATCH 1/8] of: provide of_machine_get_compatible()

On Mon Jan 19, 2026 at 11:40 AM CET, Bartosz Golaszewski wrote:
> +/**
> + * of_machine_get_compatible - Get the compatible string of this machine
> + * @compatible: address at which the compatible string will be stored
> + *
> + * Returns:
> + * 0 on success, negative error number on failure.
> + */
> +int of_machine_get_compatible(const char **compatible)

I think the name of this function is not ideal. 'get' usually indicates that a
reference count will be taken, but this is not the case here.

I'm also not sure about the machine prefix. If we really want this helper I'd
suggest something along the lines of e.g. of_root_read_compatible().

> +{
> +	return of_property_read_string(of_root, "compatible", compatible);
> +}
> +EXPORT_SYMBOL_GPL(of_machine_get_compatible);