linux-kernel - Re: [net-next v7 5/8] net: wwan: add NMEA port support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aW91bYu1ueczfGTh@horms.kernel.org>
Date: Tue, 20 Jan 2026 12:30:37 +0000
From: Simon Horman <horms@...nel.org>
To: Slark Xiao <slark_xiao@....com>
Cc: loic.poulain@....qualcomm.com, ryazanov.s.a@...il.com,
	johannes@...solutions.net, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, mani@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Muhammad Nuzaihan <zaihan@...ealasia.net>,
	Qiang Yu <quic_qianyu@...cinc.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Johan Hovold <johan@...nel.org>
Subject: Re: [net-next v7 5/8] net: wwan: add NMEA port support

On Thu, Jan 15, 2026 at 07:46:22PM +0800, Slark Xiao wrote:

...

> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c

...

> +#else
> +static inline int wwan_port_register_gnss(struct wwan_port *port)
> +{
> +	return -EOPNOTSUPP;
> +}
> +
> +static inline void wwan_port_unregister_gnss(struct wwan_port *port)
> +{
> +	WARN_ON(1);	/* This handler cannot be called */
> +}

Please don't use the inline keyword in .c files unless there is a
demonstrable - usually performance - reason to do so. Rather, let the
compiler inline code as it sees fit.

Using the inline keyword in .h is of course fine.

> +#endif
> +

...